src/arm/disasm-arm.cc - Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/disasm-arm.cc

Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/disasm-arm.cc

diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc

index aa8ee22b73a3c4e7b92ea3312e7bd5b3da8bf96a..a0dc05796e59953089f093ccc9fd4a807ce51977 100644

--- a/src/arm/disasm-arm.cc

+++ b/src/arm/disasm-arm.cc

@@ -1272,7 +1272,7 @@ void Decoder::DecodeTypeVFP(Instruction* instr) {

} else if ((instr->Opc2Value() == 0xA) && (instr->Opc3Value() == 0x3) &&

(instr->Bit(8) == 1)) {

// vcvt.f64.s32 Dd, Dd, #<fbits>

- int fraction_bits = 32 - ((instr->Bit(5) << 4) | instr->Bits(3, 0));

+ int fraction_bits = 32 - (instr->Bit(5) | (instr->Bits(3, 0) << 1));

rmcilroy 2014/04/03 18:59:11 nit - please rewrite as: (instr->Bits(3, 0) << 1)

Format(instr, "vcvt'cond.f64.s32 'Dd, 'Dd");

out_buffer_pos_ += OS::SNPrintF(out_buffer_ + out_buffer_pos_,

", #%d", fraction_bits);