chrome/browser/resources/settings/people_page/setup_pin_dialog.html - Issue 2236213002: Add quick unlock Settings in options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Issue 2236213002: Add quick unlock Settings in options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporate comments from jdufault@ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('K') | « chrome/browser/resources/settings/people_page/password_prompt_dialog.js ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

index 0c6ab823ea8bef1e021d573be1cb65a92573850b..0680469eb5142377ca3bcbf8786abc14f6de0222 100644

--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

@@ -51,8 +51,10 @@

</div>

+ <!--TODO(xiaoyinh@): Revert changes to i18n text once we

+ don't need to support options. -->

<paper-button class="cancel-button" on-tap="onCancelTap_">

- $i18n{cancel}

+ [[i18n('cancel')]]

</paper-button>

<paper-button class="action-button" on-tap="onPinSubmit_"