Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3011)

Unified Diff: chrome/browser/resources/settings/people_page/lock_screen.js

Issue 2236213002: Add quick unlock Settings in options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporate comments from jdufault@ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/lock_screen.js
diff --git a/chrome/browser/resources/settings/people_page/lock_screen.js b/chrome/browser/resources/settings/people_page/lock_screen.js
index f296363be34d22c6969668a110d742ddcf0a9617..44ba038d7ed1f672700ffb7b2a520c77282da5c7 100644
--- a/chrome/browser/resources/settings/people_page/lock_screen.js
+++ b/chrome/browser/resources/settings/people_page/lock_screen.js
@@ -37,6 +37,17 @@ Polymer({
type: Object,
observer: 'onSetModesChanged_'
},
+
+ /**
+ * Hide enable screenlock settings if coming from options page
+ * TODO(xiaoyinh@): Remove this property once we don't support options
+ */
+ hideEnableScreenlock: {
+ type: Boolean,
+ value: false,
+ notify: true
+ },
+
},
/** selectedUnlockType is defined in LockStateBehavior. */
@@ -92,8 +103,11 @@ Polymer({
/** @private */
onPasswordClosed_: function() {
- if (!this.setModes_)
+ if (!this.setModes_) {
+ /**TODO(xiaoyinh@): Remove this event once we don't support options. */
+ this.fire('close-overlay');
settings.navigateTo(settings.Route.PEOPLE);
+ }
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698