Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3189)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2236213002: Add quick unlock Settings in options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporate comments from jdufault@ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index ffc5a62da781827ea2dc7207763f2cda46755d4c..c6fffa7dee8dd455626424959d91542ff6ac6e40 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -171,53 +171,55 @@
</div>
<div class="row keyboard">
+ <!-- TODO(xiaoyinh@): revert changes to i18n text
jdufault 2016/08/12 21:45:35 What about a comment like this? Use $i18n{id} f
xiaoyinh(OOO Sep 11-29) 2016/08/16 17:33:43 Done.
+ once we don't need to support options -->
<paper-button class="digit-button" on-tap="onNumberTap_" value="1">
- <inner-text>$i18n{pinKeyboard1}</inner-text>
+ <inner-text>[[i18n('pinKeyboard1')]]</inner-text>
</paper-button>
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
value="2">
- <inner-text>$i18n{pinKeyboard2}</inner-text>
+ <inner-text>[[i18n('pinKeyboard2')]]</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="3">
- <inner-text>$i18n{pinKeyboard3}</inner-text>
+ <inner-text>[[i18n('pinKeyboard3')]]</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="4">
- <inner-text>$i18n{pinKeyboard4}</inner-text>
+ <inner-text>[[i18n('pinKeyboard4')]]</inner-text>
</paper-button>
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
value="5">
- <inner-text>$i18n{pinKeyboard5}</inner-text>
+ <inner-text>[[i18n('pinKeyboard5')]]</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="6">
- <inner-text>$i18n{pinKeyboard6}</inner-text>
+ <inner-text>[[i18n('pinKeyboard6')]]</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<paper-button class="digit-button" on-tap="onNumberTap_" value="7">
- <inner-text>$i18n{pinKeyboard7}</inner-text>
+ <inner-text>[[i18n('pinKeyboard7')]]</inner-text>
</paper-button>
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
value="8">
- <inner-text>$i18n{pinKeyboard8}</inner-text>
+ <inner-text>[[i18n('pinKeyboard8')]]</inner-text>
</paper-button>
<paper-button class="digit-button" on-tap="onNumberTap_" value="9">
- <inner-text>$i18n{pinKeyboard9}</inner-text>
+ <inner-text>[[i18n('pinKeyboard9')]]</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<div class="digit-button"></div>
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
value="0">
- <inner-text>$i18n{pinKeyboard0}</inner-text>
+ <inner-text>[[i18n('pinKeyboard0')]]</inner-text>
</paper-button>
<paper-button class="digit-button clear-button" on-tap="onPinClear_">
<div class="icon-container">
<iron-icon class="icon" icon="cr:clear"><iron-icon>
</div>
<inner-text class="icon-subheading">
- $i18n{pinKeyboardClear}
+ [[i18n('pinKeyboardClear')]]
</inner-text>
</paper-button>
</div>
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698