Add quick unlock Settings in options page

chrome/browser/resources/options/route_stub.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// TODO(xiaoyinh@): This file is a stub class of
+// chrome/browser/resources/settings/route.js. And it is used to integrate
+// with the polymer elements in settings.
+// It should be removed once we don't need to support options.

[stevenjb, 2016/08/16 20:59:52]

This is one of the pieces that strikes me as somewhat fragile. It would be nice
if we could avoid the need for it somehow.

[xiaoyinh(OOO Sep 11-29), 2016/08/17 20:52:11]

I have removed most of it, please take a look. Thanks!

+
+cr.define('settings', function() {
+  /**
+   * Class for navigable routes. May only be instantiated within this file.
+   * @constructor
+   * @param {string} path
+   * @private
+   */
+  var Route = function(path) {
+    this.path = path;
+  };
+
+  // Abbreviated variable for easier definitions.
+  var r = Route;
+
+  // Root pages.
+  r.BASIC = new Route('/');
+  r.PEOPLE = r.BASIC;
+<if expr="chromeos">

[jdufault, 2016/08/16 17:43:14]

This file should only be included if we're on cros, can we drop the <if>?

[xiaoyinh(OOO Sep 11-29), 2016/08/17 20:52:11]

Removed, thanks!

+  r.LOCK_SCREEN = new Route('/quickUnlockConfigureOverlay');
+</if>
+
+  var routeObservers_ = new Set();
+
+  /** @polymerBehavior */
+  var RouteObserverBehavior = {
+    /** @override */
+    attached: function() {
+      assert(!routeObservers_.has(this));
+      routeObservers_.add(this);
+
+      // Emulating Polymer data bindings, the observer is called when the
+      // element starts observing the route.
+      this.currentRouteChanged(currentRoute_, undefined);
+    },
+
+    /** @override */
+    detached: function() {
+      assert(routeObservers_.delete(this));
+    },
+
+    /** @abstract */
+    currentRouteChanged: assertNotReached,
+  };
+
+  /**
+   * Returns the matching canonical route, or null if none matches.
+   * @param {string} path
+   * @return {?settings.Route}
+   * @private
+   */
+  var getRouteForPath = function(path) {
+    var matchingKey = Object.keys(Route).find(function(key) {
+      return Route[key].path == path;
+    });
+
+    return Route[matchingKey] || null;
+  };
+
+  /**
+   * The current active route. This updated only by settings.navigateTo.
+   * @private {!settings.Route}
+   */
+  var currentRoute_ = Route.BASIC;
+
+
+  // Initialize the route from the URL.
+  (function() {
+    var route = getRouteForPath(window.location.pathname);
+    if (route) {
+      currentRoute_ = route;
+    } else {
+      // Do nothing
+    }
+  })();
+
+  /**
+   * Helper function to set the current route and notify all observers.
+   * @param {!settings.Route} route
+   */
+  var setCurrentRoute = function(route) {
+    var oldRoute = currentRoute_;
+    currentRoute_ = route;
+    for (var observer of routeObservers_)
+      observer.currentRouteChanged(currentRoute_, oldRoute);
+  };
+
+  var getCurrentRoute = function() { return currentRoute_; };
+
+  var navigateTo = function(route) {
+    setCurrentRoute(route);
+  };
+
+  window.addEventListener('popstate', function(event) {
+    // On pop state, do not push the state onto the window.history again.
+    setCurrentRoute(getRouteForPath(window.location.pathname) || Route.BASIC);
+  });
+
+  return {

[tommycli, 2016/08/17 21:19:58]

I think in this whole file, all you need is:

var Route = {
  LOCK_SCREEN: 0,
},

return {
  Route: Route,
  getCurrentRoute: function() { return Route.LOCK_SCREEN; },
  RouteObserverBehavior: {},
}

[xiaoyinh(OOO Sep 11-29), 2016/08/18 22:41:12]

This file has been removed. Thanks!

+    Route: Route,
+    RouteObserverBehavior: RouteObserverBehavior,
+    getRouteForPath: getRouteForPath,
+    getCurrentRoute: getCurrentRoute,
+    navigateTo: navigateTo,
+  };
+});