Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out | 1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out |
| 2 what i18n to use for keypad, ie, does 1 ABC make | 2 what i18n to use for keypad, ie, does 1 ABC make |
| 3 sense in every scenario? --> | 3 sense in every scenario? --> |
| 4 | 4 |
| 5 <link rel="import" href="chrome://resources/cr_elements/icons.html"> | 5 <link rel="import" href="chrome://resources/cr_elements/icons.html"> |
| 6 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | 6 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> |
| 7 <link rel="import" href="chrome://resources/html/polymer.html"> | 7 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> |
| 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> | 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> |
| 10 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> | 10 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> |
| (...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 164 <paper-button class$="digit-button first-row submit-button | 164 <paper-button class$="digit-button first-row submit-button |
| 165 [[getSubmitHiddenClass_(enableSubmitButton)]]" | 165 [[getSubmitHiddenClass_(enableSubmitButton)]]" |
| 166 on-tap="firePinSubmitEvent_"> | 166 on-tap="firePinSubmitEvent_"> |
| 167 <div class$="icon-container [[getSubmitClass_(value)]]"> | 167 <div class$="icon-container [[getSubmitClass_(value)]]"> |
| 168 <iron-icon class="icon" icon="pin-keyboard:forward"><iron-icon> | 168 <iron-icon class="icon" icon="pin-keyboard:forward"><iron-icon> |
| 169 </div> | 169 </div> |
| 170 </paper-button> | 170 </paper-button> |
| 171 </div> | 171 </div> |
| 172 | 172 |
| 173 <div class="row keyboard"> | 173 <div class="row keyboard"> |
| 174 <!-- TODO(xiaoyinh@): Use this format: $i18n{pinKeyboardClear} | |
|
tommycli
2016/08/16 20:08:35
+dschuyler: Can we make Options just i18n pre-proc
xiaoyinh(OOO Sep 11-29)
2016/08/17 20:52:11
Done.
| |
| 175 once we don't need to support options --> | |
| 174 <paper-button class="digit-button" on-tap="onNumberTap_" value="1"> | 176 <paper-button class="digit-button" on-tap="onNumberTap_" value="1"> |
| 175 <inner-text>$i18n{pinKeyboard1}</inner-text> | 177 <inner-text>[[i18n('pinKeyboard1')]]</inner-text> |
|
stevenjb
2016/08/16 20:59:52
I hate that we need to do all of these changes jus
xiaoyinh(OOO Sep 11-29)
2016/08/17 20:52:11
After adding i18n pre-process in options, this par
| |
| 176 </paper-button> | 178 </paper-button> |
| 177 <paper-button class="digit-button center-button" on-tap="onNumberTap_" | 179 <paper-button class="digit-button center-button" on-tap="onNumberTap_" |
| 178 value="2"> | 180 value="2"> |
| 179 <inner-text>$i18n{pinKeyboard2}</inner-text> | 181 <inner-text>[[i18n('pinKeyboard2')]]</inner-text> |
| 180 </paper-button> | 182 </paper-button> |
| 181 <paper-button class="digit-button" on-tap="onNumberTap_" value="3"> | 183 <paper-button class="digit-button" on-tap="onNumberTap_" value="3"> |
| 182 <inner-text>$i18n{pinKeyboard3}</inner-text> | 184 <inner-text>[[i18n('pinKeyboard3')]]</inner-text> |
| 183 </paper-button> | 185 </paper-button> |
| 184 </div> | 186 </div> |
| 185 <div class="row keyboard"> | 187 <div class="row keyboard"> |
| 186 <paper-button class="digit-button" on-tap="onNumberTap_" value="4"> | 188 <paper-button class="digit-button" on-tap="onNumberTap_" value="4"> |
| 187 <inner-text>$i18n{pinKeyboard4}</inner-text> | 189 <inner-text>[[i18n('pinKeyboard4')]]</inner-text> |
| 188 </paper-button> | 190 </paper-button> |
| 189 <paper-button class="digit-button center-button" on-tap="onNumberTap_" | 191 <paper-button class="digit-button center-button" on-tap="onNumberTap_" |
| 190 value="5"> | 192 value="5"> |
| 191 <inner-text>$i18n{pinKeyboard5}</inner-text> | 193 <inner-text>[[i18n('pinKeyboard5')]]</inner-text> |
| 192 </paper-button> | 194 </paper-button> |
| 193 <paper-button class="digit-button" on-tap="onNumberTap_" value="6"> | 195 <paper-button class="digit-button" on-tap="onNumberTap_" value="6"> |
| 194 <inner-text>$i18n{pinKeyboard6}</inner-text> | 196 <inner-text>[[i18n('pinKeyboard6')]]</inner-text> |
| 195 </paper-button> | 197 </paper-button> |
| 196 </div> | 198 </div> |
| 197 <div class="row keyboard"> | 199 <div class="row keyboard"> |
| 198 <paper-button class="digit-button" on-tap="onNumberTap_" value="7"> | 200 <paper-button class="digit-button" on-tap="onNumberTap_" value="7"> |
| 199 <inner-text>$i18n{pinKeyboard7}</inner-text> | 201 <inner-text>[[i18n('pinKeyboard7')]]</inner-text> |
| 200 </paper-button> | 202 </paper-button> |
| 201 <paper-button class="digit-button center-button" on-tap="onNumberTap_" | 203 <paper-button class="digit-button center-button" on-tap="onNumberTap_" |
| 202 value="8"> | 204 value="8"> |
| 203 <inner-text>$i18n{pinKeyboard8}</inner-text> | 205 <inner-text>[[i18n('pinKeyboard8')]]</inner-text> |
| 204 </paper-button> | 206 </paper-button> |
| 205 <paper-button class="digit-button" on-tap="onNumberTap_" value="9"> | 207 <paper-button class="digit-button" on-tap="onNumberTap_" value="9"> |
| 206 <inner-text>$i18n{pinKeyboard9}</inner-text> | 208 <inner-text>[[i18n('pinKeyboard9')]]</inner-text> |
| 207 </paper-button> | 209 </paper-button> |
| 208 </div> | 210 </div> |
| 209 <div class="row keyboard"> | 211 <div class="row keyboard"> |
| 210 <div class="digit-button"></div> | 212 <div class="digit-button"></div> |
| 211 <paper-button class="digit-button center-button" on-tap="onNumberTap_" | 213 <paper-button class="digit-button center-button" on-tap="onNumberTap_" |
| 212 value="0"> | 214 value="0"> |
| 213 <inner-text>$i18n{pinKeyboard0}</inner-text> | 215 <inner-text>[[i18n('pinKeyboard0')]]</inner-text> |
| 214 </paper-button> | 216 </paper-button> |
| 215 <paper-button class="digit-button clear-button" on-tap="onPinClear_"> | 217 <paper-button class="digit-button clear-button" on-tap="onPinClear_"> |
| 216 <div class="icon-container"> | 218 <div class="icon-container"> |
| 217 <iron-icon class="icon" icon="cr:clear"><iron-icon> | 219 <iron-icon class="icon" icon="cr:clear"><iron-icon> |
| 218 </div> | 220 </div> |
| 219 <inner-text class="icon-subheading"> | 221 <inner-text class="icon-subheading"> |
| 220 $i18n{pinKeyboardClear} | 222 [[i18n('pinKeyboardClear')]] |
| 221 </inner-text> | 223 </inner-text> |
| 222 </paper-button> | 224 </paper-button> |
| 223 </div> | 225 </div> |
| 224 </div> | 226 </div> |
| 225 </div> | 227 </div> |
| 226 </template> | 228 </template> |
| 227 <script src="pin_keyboard.js"></script> | 229 <script src="pin_keyboard.js"></script> |
| 228 </dom-module> | 230 </dom-module> |
| OLD | NEW |