Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2236143002: Add live output for blimp integration script {run} func (Closed)

Created:
4 years, 4 months ago by shenghuazhang
Modified:
4 years, 4 months ago
Reviewers:
nyquist
CC:
jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add live output for blimp integration script {run} func Support for getting console log from the engine. Print the logs to stdout for {run} positional argument. BUG=636410 Committed: https://crrev.com/8207e3a60214c97137ccb86ecd714a750124047c Cr-Commit-Position: refs/heads/master@{#411705}

Patch Set 1 #

Patch Set 2 : use sys.stdout.write instead of print #

Total comments: 2

Patch Set 3 : log error when engine fails to start #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M blimp/tools/client_engine_integration.py View 1 2 4 chunks +12 lines, -7 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
shenghuazhang
4 years, 4 months ago (2016-08-11 02:54:55 UTC) #2
shenghuazhang
This change prints output of engine process as default when using {run} as the positional ...
4 years, 4 months ago (2016-08-11 02:58:42 UTC) #3
nyquist
https://codereview.chromium.org/2236143002/diff/20001/blimp/tools/client_engine_integration.py File blimp/tools/client_engine_integration.py (right): https://codereview.chromium.org/2236143002/diff/20001/blimp/tools/client_engine_integration.py#newcode179 blimp/tools/client_engine_integration.py:179: if engine_process.poll() is None: If this is not the ...
4 years, 4 months ago (2016-08-11 23:09:43 UTC) #4
shenghuazhang
Log error when engine fails to start. https://codereview.chromium.org/2236143002/diff/20001/blimp/tools/client_engine_integration.py File blimp/tools/client_engine_integration.py (right): https://codereview.chromium.org/2236143002/diff/20001/blimp/tools/client_engine_integration.py#newcode179 blimp/tools/client_engine_integration.py:179: if engine_process.poll() ...
4 years, 4 months ago (2016-08-12 00:24:36 UTC) #5
nyquist
assuming the answer to the only comment is yes, this lgtm! https://codereview.chromium.org/2236143002/diff/40001/blimp/tools/client_engine_integration.py File blimp/tools/client_engine_integration.py (right): ...
4 years, 4 months ago (2016-08-12 03:45:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236143002/40001
4 years, 4 months ago (2016-08-12 17:31:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 18:25:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 18:28:40 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8207e3a60214c97137ccb86ecd714a750124047c
Cr-Commit-Position: refs/heads/master@{#411705}

Powered by Google App Engine
This is Rietveld 408576698