Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2236123002:
Fix CopyTextureCHROMIUM on core profile. (Closed)
|
Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 4 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org, piman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix CopyTextureCHROMIUM on core profile.
When clearing a GL_ALPHA type texture via TexSubImage2D, it's
necessary to map the format to one which is supported on the core
profile.
Also make error messages more precise.
TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile
BUG=635081
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/f7b35521f615bd322743916191d78139e3d23e90
Cr-Commit-Position: refs/heads/master@{#411279}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. TEST=gl_tests on Core Profile BUG=635081 ========== to ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. TEST=gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. TEST=gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. Also make error messages more precise. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
PTAL. Tested locally.
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. Also make error messages more precise. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. Also make error messages more precise. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. Also make error messages more precise. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix CopyTextureCHROMIUM on core profile. When clearing a GL_ALPHA type texture via TexSubImage2D, it's necessary to map the format to one which is supported on the core profile. Also make error messages more precise. TEST=CopyType/GLCopyTextureCHROMIUMTest.InternalFormat* from gl_tests on Core Profile BUG=635081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f7b35521f615bd322743916191d78139e3d23e90 Cr-Commit-Position: refs/heads/master@{#411279} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f7b35521f615bd322743916191d78139e3d23e90 Cr-Commit-Position: refs/heads/master@{#411279} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
