Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: blimp/net/blimp_transport.h

Issue 2236093002: Decouple Blimp transport output from BlimpConnections using MessagePort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@statistics-singleton
Patch Set: lethalantidote feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_transport.h
diff --git a/blimp/net/blimp_transport.h b/blimp/net/blimp_transport.h
index e74bb164b9c745fe49ee94f6e61220099eb24e85..5d06632b2e9af0d5bc18c62f8af78c167922c177 100644
--- a/blimp/net/blimp_transport.h
+++ b/blimp/net/blimp_transport.h
@@ -13,6 +13,7 @@
namespace blimp {
class BlimpConnection;
+class MessagePort;
// An interface which encapsulates the transport-specific code for
// establishing network connections between the client and engine.
@@ -24,17 +25,16 @@ class BlimpTransport {
// Initiate or listen for a connection.
//
- // |callback| will be invoked with the connection outcome:
- // * net::OK if a connection is established successful, the BlimpConnection
- // can be taken by calling TakeConnection().
- // * net::ERR_IO_PENDING will never be the outcome
- // * Other error code indicates no connection was established.
+ // |callback| is passed net::OK if a connection was successfully
+ // established. The connection's MessagePort can then be taken by calling
+ // TakeMessagePort().
+ // All other values indicate a connection error.
virtual void Connect(const net::CompletionCallback& callback) = 0;
- // Returns the connection object after a successful Connect().
- virtual std::unique_ptr<BlimpConnection> TakeConnection() = 0;
+ // Returns the MessagePort of a successfully established connection.
+ virtual std::unique_ptr<MessagePort> TakeMessagePort() = 0;
- // Gets transport name, e.g. "TCP", "SSL", "mock", etc.
+ // Gets the transport name, e.g. "TCP", "SSL", "mock", etc.
virtual const char* GetName() const = 0;
};

Powered by Google App Engine
This is Rietveld 408576698