Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3317)

Unified Diff: blimp/net/tcp_client_transport.cc

Issue 2236093002: Decouple Blimp transport output from BlimpConnections using MessagePort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@statistics-singleton
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/tcp_client_transport.cc
diff --git a/blimp/net/tcp_client_transport.cc b/blimp/net/tcp_client_transport.cc
index 173396b071ba35d34182df43909c5b90d6b87aa7..54d60c6d8f84c16606ae700b030a9c97cd36f9d0 100644
--- a/blimp/net/tcp_client_transport.cc
+++ b/blimp/net/tcp_client_transport.cc
@@ -11,6 +11,8 @@
#include "base/callback_helpers.h"
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
+#include "blimp/net/message_port.h"
+#include "blimp/net/message_port_util.h"
#include "blimp/net/stream_socket_connection.h"
#include "net/socket/client_socket_factory.h"
#include "net/socket/stream_socket.h"
@@ -50,10 +52,10 @@ void TCPClientTransport::Connect(const net::CompletionCallback& callback) {
OnTCPConnectComplete(result);
}
-std::unique_ptr<BlimpConnection> TCPClientTransport::TakeConnection() {
+std::unique_ptr<MessagePort> TCPClientTransport::TakeMessagePort() {
DCHECK(connect_callback_.is_null());
DCHECK(socket_);
- return base::MakeUnique<StreamSocketConnection>(std::move(socket_));
+ return CreateMessagePortForStreamSocket(std::move(socket_));
}
const char* TCPClientTransport::GetName() const {

Powered by Google App Engine
This is Rietveld 408576698