Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: blimp/net/blimp_connection.h

Issue 2236093002: Decouple Blimp transport output from BlimpConnections using MessagePort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@statistics-singleton
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_connection.h
diff --git a/blimp/net/blimp_connection.h b/blimp/net/blimp_connection.h
index 51070d0c7665ab9b74685f6577dc41489b5c28e2..10450d0a2853b79f13282138a717f267136df8bc 100644
--- a/blimp/net/blimp_connection.h
+++ b/blimp/net/blimp_connection.h
@@ -17,16 +17,13 @@ namespace blimp {
class BlimpMessageProcessor;
class BlimpMessagePump;
class BlimpMessageSender;
-class PacketReader;
-class PacketWriter;
+class MessagePort;
// Encapsulates the state and logic used to exchange BlimpMessages over
// a network connection.
class BLIMP_NET_EXPORT BlimpConnection : public ConnectionErrorObserver {
public:
- BlimpConnection(std::unique_ptr<PacketReader> reader,
- std::unique_ptr<PacketWriter> writer);
-
+ explicit BlimpConnection(std::unique_ptr<MessagePort> message_port);
~BlimpConnection() override;
// Adds |observer| to the connection's error observer list.
@@ -53,9 +50,8 @@ class BLIMP_NET_EXPORT BlimpConnection : public ConnectionErrorObserver {
void OnConnectionError(int error) override;
private:
- std::unique_ptr<PacketReader> reader_;
+ std::unique_ptr<MessagePort> message_port_;
std::unique_ptr<BlimpMessagePump> message_pump_;
- std::unique_ptr<PacketWriter> writer_;
std::unique_ptr<BlimpMessageSender> outgoing_msg_processor_;
base::ObserverList<ConnectionErrorObserver> error_observers_;
std::unique_ptr<EndConnectionFilter> end_connection_filter_;
« no previous file with comments | « blimp/net/BUILD.gn ('k') | blimp/net/blimp_connection.cc » ('j') | blimp/net/blimp_transport.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698