Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2236033003: Make downloaded WebAPK world readable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'webapk_builder_impl2_thread' into webapk_thread_install Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index 3c18002005e730d6976687d6a06bab77892cafdf..6b8f3633298dc6322404b1541e7635fdc46cab38 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -83,14 +83,24 @@ class WebApkInstaller : public net::URLFetcherDelegate {
void OnGotWebApkDownloadUrl(const GURL& download_url,
const std::string& package_name);
- // Called once the WebAPK has been downloaded. Installs the WebAPK if the
- // download was successful.
+ // Called once the WebAPK has been downloaded. Makes the downloaded WebAPK
+ // world readable and installs the WebAPK if the download was successful.
// |file_path| is the file path that the WebAPK was downloaded to.
// |package_name| is the package name that the WebAPK should be installed at.
void OnWebApkDownloaded(const base::FilePath& file_path,
const std::string& package_name,
FileDownloader::Result result);
+ // Called once the downloaded WebAPK has been made world readable. Installs
+ // the WebAPK.
+ // |file_path| is the file path that the WebAPK was downloaded to.
+ // |package_name| is the package name that the WebAPK should be installed at.
+ // |change_permission_success| is whether the WebAPK could be made world
+ // readable.
+ void OnWebApkMadeWorldReadable(const base::FilePath& file_path,
+ const std::string& package_name,
+ bool change_permission_success);
+
// Populates webapk::WebApk and returns it.
// Must be called on a worker thread because it encodes an SkBitmap.
std::unique_ptr<webapk::WebApk> BuildWebApkProtoInBackground();

Powered by Google App Engine
This is Rietveld 408576698