[DevTools] Simplify evaluation callbacks on frontend

third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

 /*
  * Copyright (C) IBM Corp. 2009  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 215 matching lines @@
  * @param {!WebInspector.Linkifier} linkifier
  */
 WebInspector.WatchExpression = function(expression, expandController, linkifier)
 {
     this._expression = expression;
     this._expandController = expandController;
     this._element = createElementWithClass("div", "watch-expression monospace");
     this._editing = false;
     this._linkifier = linkifier;
 
-    this._createWatchExpression(null, false);
+    this._createWatchExpression(null);
     this.update();
 }
 
 WebInspector.WatchExpression._watchObjectGroupId = "watch-group";
 
 WebInspector.WatchExpression.Events = {
     ExpressionUpdated: "ExpressionUpdated"
 }
 
 WebInspector.WatchExpression.prototype = {
@@ skipping 87 matching lines @@
      * @param {!Event} event
      */
     _deleteWatchExpression: function(event)
     {
         event.consume(true);
         this._updateExpression(null);
     },
 
     /**
      * @param {?WebInspector.RemoteObject} result
-     * @param {boolean} wasThrown
+     * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
      */
-    _createWatchExpression: function(result, wasThrown)
+    _createWatchExpression: function(result, exceptionDetails)
     {
         this._result = result;
 
         var headerElement = createElementWithClass("div", "watch-expression-header");
         var deleteButton = headerElement.createChild("button", "watch-expression-delete-button");
         deleteButton.title = WebInspector.UIString("Delete watch expression");
         deleteButton.addEventListener("click", this._deleteWatchExpression.bind(this), false);
 
         var titleElement = headerElement.createChild("div", "watch-expression-title");
         this._nameElement = WebInspector.ObjectPropertiesSection.createNameElement(this._expression);
-        if (wasThrown || !result) {
+        if (!!exceptionDetails || !result) {
             this._valueElement = createElementWithClass("span", "error-message value");
             titleElement.classList.add("dimmed");
             this._valueElement.textContent = WebInspector.UIString("<not available>");
         } else {
-            this._valueElement = WebInspector.ObjectPropertiesSection.createValueElementWithCustomSupport(result, wasThrown, titleElement, this._linkifier);
+            this._valueElement = WebInspector.ObjectPropertiesSection.createValueElementWithCustomSupport(result, !!exceptionDetails, titleElement, this._linkifier);
         }
         var separatorElement = createElementWithClass("span", "watch-expressions-separator");
         separatorElement.textContent = ": ";
         titleElement.appendChildren(this._nameElement, separatorElement, this._valueElement);
 
         this._element.removeChildren();
         this._objectPropertiesSection = null;
-        if (!wasThrown && result && result.hasChildren && !result.customPreview()) {
+        if (!exceptionDetails && result && result.hasChildren && !result.customPreview()) {
             headerElement.classList.add("watch-expression-object-header");
             this._objectPropertiesSection = new WebInspector.ObjectPropertiesSection(result, headerElement, this._linkifier);
             this._objectPresentationElement = this._objectPropertiesSection.element;
             this._expandController.watchSection(/** @type {string} */ (this._expression), this._objectPropertiesSection);
             var objectTreeElement = this._objectPropertiesSection.objectTreeElement();
             objectTreeElement.toggleOnClick = false;
             objectTreeElement.listItemElement.addEventListener("click", this._onSectionClick.bind(this), false);
             objectTreeElement.listItemElement.addEventListener("dblclick", this._dblClickOnWatchExpression.bind(this));
         } else {
             this._objectPresentationElement = headerElement;
@@ skipping 57 matching lines @@
             contextMenu.appendApplicableItems(this._result);
     },
 
     _copyValueButtonClicked: function()
     {
         InspectorFrontendHost.copyText(this._valueElement.textContent);
     },
 
     __proto__: WebInspector.Object.prototype
 }