Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 960 matching lines...) Expand 10 before | Expand all | Expand 10 after
971 971
972 /** 972 /**
973 * @param {!WebInspector.RemoteObject} remoteObject 973 * @param {!WebInspector.RemoteObject} remoteObject
974 */ 974 */
975 _saveToTempVariable: function(remoteObject) 975 _saveToTempVariable: function(remoteObject)
976 { 976 {
977 var currentExecutionContext = WebInspector.context.flavor(WebInspector.E xecutionContext); 977 var currentExecutionContext = WebInspector.context.flavor(WebInspector.E xecutionContext);
978 if (!currentExecutionContext) 978 if (!currentExecutionContext)
979 return; 979 return;
980 980
981 currentExecutionContext.globalObject("", false, false, didGetGlobalObjec t); 981 currentExecutionContext.globalObject("", false, didGetGlobalObject);
982 /** 982 /**
983 * @param {?WebInspector.RemoteObject} global 983 * @param {?WebInspector.RemoteObject} global
984 * @param {boolean=} wasThrown 984 * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
985 */ 985 */
986 function didGetGlobalObject(global, wasThrown) 986 function didGetGlobalObject(global, exceptionDetails)
987 { 987 {
988 /** 988 /**
989 * @suppressReceiverCheck 989 * @suppressReceiverCheck
990 * @this {Window} 990 * @this {Window}
991 */ 991 */
992 function remoteFunction(value) 992 function remoteFunction(value)
993 { 993 {
994 var prefix = "temp"; 994 var prefix = "temp";
995 var index = 1; 995 var index = 1;
996 while ((prefix + index) in this) 996 while ((prefix + index) in this)
997 ++index; 997 ++index;
998 var name = prefix + index; 998 var name = prefix + index;
999 this[name] = value; 999 this[name] = value;
1000 return name; 1000 return name;
1001 } 1001 }
1002 1002
1003 if (wasThrown || !global) 1003 if (!!exceptionDetails || !global)
1004 failedToSave(global); 1004 failedToSave(global);
1005 else 1005 else
1006 global.callFunction(remoteFunction, [WebInspector.RemoteObject.t oCallArgument(remoteObject)], didSave.bind(null, global)); 1006 global.callFunction(remoteFunction, [WebInspector.RemoteObject.t oCallArgument(remoteObject)], didSave.bind(null, global));
1007 } 1007 }
1008 1008
1009 /** 1009 /**
1010 * @param {!WebInspector.RemoteObject} global 1010 * @param {!WebInspector.RemoteObject} global
1011 * @param {?WebInspector.RemoteObject} result 1011 * @param {?WebInspector.RemoteObject} result
1012 * @param {boolean=} wasThrown 1012 * @param {boolean=} wasThrown
1013 */ 1013 */
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 __proto__: WebInspector.VBox.prototype 1436 __proto__: WebInspector.VBox.prototype
1437 } 1437 }
1438 1438
1439 /** 1439 /**
1440 * @return {boolean} 1440 * @return {boolean}
1441 */ 1441 */
1442 WebInspector.SourcesPanel.WrapperView.isShowing = function() 1442 WebInspector.SourcesPanel.WrapperView.isShowing = function()
1443 { 1443 {
1444 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing(); 1444 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing();
1445 } 1445 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698