Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 1010
1011 /** 1011 /**
1012 * @param {!WebInspector.RemoteObject} remoteObject 1012 * @param {!WebInspector.RemoteObject} remoteObject
1013 */ 1013 */
1014 _saveToTempVariable: function(remoteObject) 1014 _saveToTempVariable: function(remoteObject)
1015 { 1015 {
1016 var currentExecutionContext = WebInspector.context.flavor(WebInspector.E xecutionContext); 1016 var currentExecutionContext = WebInspector.context.flavor(WebInspector.E xecutionContext);
1017 if (!currentExecutionContext) 1017 if (!currentExecutionContext)
1018 return; 1018 return;
1019 1019
1020 currentExecutionContext.globalObject("", false, false, didGetGlobalObjec t); 1020 currentExecutionContext.globalObject("", false, didGetGlobalObject);
1021 /** 1021 /**
1022 * @param {?WebInspector.RemoteObject} global 1022 * @param {?WebInspector.RemoteObject} global
1023 * @param {boolean=} wasThrown 1023 * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
1024 */ 1024 */
1025 function didGetGlobalObject(global, wasThrown) 1025 function didGetGlobalObject(global, exceptionDetails)
1026 { 1026 {
1027 /** 1027 /**
1028 * @suppressReceiverCheck 1028 * @suppressReceiverCheck
1029 * @this {Window} 1029 * @this {Window}
1030 */ 1030 */
1031 function remoteFunction(value) 1031 function remoteFunction(value)
1032 { 1032 {
1033 var prefix = "temp"; 1033 var prefix = "temp";
1034 var index = 1; 1034 var index = 1;
1035 while ((prefix + index) in this) 1035 while ((prefix + index) in this)
1036 ++index; 1036 ++index;
1037 var name = prefix + index; 1037 var name = prefix + index;
1038 this[name] = value; 1038 this[name] = value;
1039 return name; 1039 return name;
1040 } 1040 }
1041 1041
1042 if (wasThrown || !global) 1042 if (!!exceptionDetails || !global)
1043 failedToSave(global); 1043 failedToSave(global);
1044 else 1044 else
1045 global.callFunction(remoteFunction, [WebInspector.RemoteObject.t oCallArgument(remoteObject)], didSave.bind(null, global)); 1045 global.callFunction(remoteFunction, [WebInspector.RemoteObject.t oCallArgument(remoteObject)], didSave.bind(null, global));
1046 } 1046 }
1047 1047
1048 /** 1048 /**
1049 * @param {!WebInspector.RemoteObject} global 1049 * @param {!WebInspector.RemoteObject} global
1050 * @param {?WebInspector.RemoteObject} result 1050 * @param {?WebInspector.RemoteObject} result
1051 * @param {boolean=} wasThrown 1051 * @param {boolean=} wasThrown
1052 */ 1052 */
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
1478 __proto__: WebInspector.VBox.prototype 1478 __proto__: WebInspector.VBox.prototype
1479 } 1479 }
1480 1480
1481 /** 1481 /**
1482 * @return {boolean} 1482 * @return {boolean}
1483 */ 1483 */
1484 WebInspector.SourcesPanel.WrapperView.isShowing = function() 1484 WebInspector.SourcesPanel.WrapperView.isShowing = function()
1485 { 1485 {
1486 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing(); 1486 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing();
1487 } 1487 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698