Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 223603005: Expose WebView::setOpenedByDOM. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Expose WebView::setOpenedByDOM. Sets the openedByDOM bit on the Page. This is used to determine whether window.close() may be called. Expose this so the state may be managed by the WebContents and plumbed down as Pages are created. A follow-up change will remove the two existing calls to Page::setOpenedByDOM after the value becomes managed by Chromium. BUG=357579 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171167

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Source/web/WebViewImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebView.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
abarth: This is to be used with https://codereview.chromium.org/212703005/ to synchronous the state across process swaps. ...
6 years, 8 months ago (2014-04-09 16:28:37 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-09 17:28:05 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-09 18:16:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/223603005/20001
6 years, 8 months ago (2014-04-09 18:16:33 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 19:08:36 UTC) #5
Message was sent while issue was closed.
Change committed as 171167

Powered by Google App Engine
This is Rietveld 408576698