Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2236013002: update textblob api to use sk_sp (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update textblob api to use sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236013002 NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/2ab9057b31ee92060b9769ea1adfada51c11c010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M include/core/SkCanvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkTextBlob.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/core/SkTextBlob.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
reed1
4 years, 4 months ago (2016-08-10 20:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236013002/1
4 years, 4 months ago (2016-08-10 20:38:00 UTC) #5
f(malita)
lgtm
4 years, 4 months ago (2016-08-10 20:39:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236013002/1
4 years, 4 months ago (2016-08-10 21:04:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236013002/1
4 years, 4 months ago (2016-08-10 21:15:45 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:16:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ab9057b31ee92060b9769ea1adfada51c11c010

Powered by Google App Engine
This is Rietveld 408576698