Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2235983003: [builtins] Migrate StringToNumber to TurboFan builtin. (Closed)

Created:
4 years, 4 months ago by alegil02
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate StringToNumber to TurboFan builtin. Migrate the platform StringToNumber builtin to TurboFan. BUG=v8:5049 Committed: https://crrev.com/ab32e67f868aa4b6dc44f3e31a486847c6ca7c30 Cr-Commit-Position: refs/heads/master@{#38573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -228 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alegil02
4 years, 4 months ago (2016-08-11 08:16:52 UTC) #3
Benedikt Meurer
Awesome. LGTM, thanks.
4 years, 4 months ago (2016-08-11 09:34:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235983003/1
4 years, 4 months ago (2016-08-11 09:44:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 10:09:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 10:10:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab32e67f868aa4b6dc44f3e31a486847c6ca7c30
Cr-Commit-Position: refs/heads/master@{#38573}

Powered by Google App Engine
This is Rietveld 408576698