Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2235953003: Revert "Remove generalized gradient code" (Closed)

Created:
4 years, 4 months ago by fmenozzi
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Remove generalized gradient code" This reverts commit 0c63006b88a16e3418d92852a62771615799839d. BUG=skia: NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235953003 Committed: https://skia.googlesource.com/skia/+/568de46cb1ac9d5a996fb52c6cf85568415a14ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -480 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 5 chunks +190 lines, -408 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 11 chunks +37 lines, -72 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fmenozzi
When I tried to revert on the code review site, I got a conflict with ...
4 years, 4 months ago (2016-08-10 19:17:38 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-08-10 19:26:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235953003/1
4 years, 4 months ago (2016-08-10 19:27:02 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 20:01:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/568de46cb1ac9d5a996fb52c6cf85568415a14ea

Powered by Google App Engine
This is Rietveld 408576698