Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2235933002: Add POINTER_TYPE_ERASER to EventPointerType (Closed)

Created:
4 years, 4 months ago by denniskempin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add POINTER_TYPE_ERASER to EventPointerType This pointer type can be used by graphics tablets, frequently the back-side of a stylus. BUG=636458 TEST=Use rubber tool and watch generated mouse events. Committed: https://crrev.com/b90b789aea11dd97a7daa98bec8dd96d2f89f205 Committed: https://crrev.com/38c0fefc07e2b842137acdc0242f6896355a977c Cr-Original-Commit-Position: refs/heads/master@{#414146} Cr-Commit-Position: refs/heads/master@{#414533}

Patch Set 1 #

Patch Set 2 : Add POINTER_TYPE_RUBBER to EventPointerType #

Patch Set 3 : Add POINTER_TYPE_RUBBER to EventPointerType #

Patch Set 4 : updated to new pen implementation #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M components/exo/wayland/server.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/blink/web_input_event.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/event_constants.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (15 generated)
denniskempin
PTAL. A pretty simple change that adds the eraser tool to EventPointerType and makes sure ...
4 years, 4 months ago (2016-08-18 19:40:02 UTC) #2
spang
lgtm
4 years, 4 months ago (2016-08-18 19:47:54 UTC) #5
reveman
lgtm
4 years, 4 months ago (2016-08-18 20:20:49 UTC) #6
sadrul
lgtm
4 years, 4 months ago (2016-08-18 20:42:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235933002/80001
4 years, 4 months ago (2016-08-24 16:43:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129025)
4 years, 4 months ago (2016-08-24 19:49:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235933002/80001
4 years, 4 months ago (2016-08-24 19:52:37 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-24 21:15:14 UTC) #16
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/b90b789aea11dd97a7daa98bec8dd96d2f89f205 Cr-Commit-Position: refs/heads/master@{#414146}
4 years, 3 months ago (2016-08-24 21:17:05 UTC) #18
msw
It seems like this broke the build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45081/steps/compile/logs/stdio
4 years, 3 months ago (2016-08-25 04:36:01 UTC) #20
msw
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2278033003/ by msw@chromium.org. ...
4 years, 3 months ago (2016-08-25 04:39:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235933002/80001
4 years, 3 months ago (2016-08-25 17:19:16 UTC) #24
denniskempin
re-submitting since the error was caused by a conflict with https://codereview.chromium.org/2270173002/ which got reverted as ...
4 years, 3 months ago (2016-08-25 17:24:33 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-25 21:02:20 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 21:03:55 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/38c0fefc07e2b842137acdc0242f6896355a977c
Cr-Commit-Position: refs/heads/master@{#414533}

Powered by Google App Engine
This is Rietveld 408576698