Issue 223593004: Revert "Return MaybeHandle from NewConsString."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223593004: Revert "Return MaybeHandle from NewConsString." (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Return MaybeHandle from NewConsString." This reverts r20473. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20475

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -117 lines)			Patch
M	src/api.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/factory.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/func-name-inferrer.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/handles.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-stringifier.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View	5 chunks	+43 lines, -50 lines	0 comments	Download
M	src/uri.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	11 chunks	+15 lines, -25 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r20475 (tree was closed).