Invalidate scrolling contents layer on background invalidations painted into it.

Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to invalidate
appropriately when those backgrounds change.

BUG=636437
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f
Cr-Commit-Position: refs/heads/master@{#411441}

[flackr, 2016-08-10 17:05:23]

Description was changed from

==========
Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to
invalidate
appropriately when those backgrounds change.

BUG=636437
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
==========

to

==========
Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to
invalidate
appropriately when those backgrounds change.

BUG=636437
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[flackr, 2016-08-10 17:09:00]

flackr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[flackr, 2016-08-10 17:09:01]

Hi Chris,

This updates the invalidation to invalidate the scrolling content when we have a
background painted into it.

I'm having a slight issue with the test for this. While running the test in
content_shell verifies that it was broken before and fixed by this patch for
some reason run-layout-tests passes without the patch. Any idea why? Perhaps a
full invalidation is occurring for some reason in the layout test?

[chrishtr, 2016-08-10 17:55:41]

On 2016/08/10 at 17:09:01, flackr wrote:
> Hi Chris,
> 
> This updates the invalidation to invalidate the scrolling content when we have
a background painted into it.
> 
> I'm having a slight issue with the test for this. While running the test in
content_shell verifies that it was broken before and fixed by this patch for
some reason run-layout-tests passes without the patch. Any idea why? Perhaps a
full invalidation is occurring for some reason in the layout test?

Try using text-based-repaint.js instead, it should be simpler and more reliable.
Also, please put the test in paint/invalidation/. There are several tests in
that directory that look for invalidations using text-based-repaint.js.

[flackr, 2016-08-11 14:37:18]

Patchset #2 (id:20001) has been deleted

[flackr, 2016-08-11 14:44:36]

On 2016/08/10 at 17:55:41, chrishtr wrote:
> On 2016/08/10 at 17:09:01, flackr wrote:
> > Hi Chris,
> > 
> > This updates the invalidation to invalidate the scrolling content when we
have a background painted into it.
> > 
> > I'm having a slight issue with the test for this. While running the test in
content_shell verifies that it was broken before and fixed by this patch for
some reason run-layout-tests passes without the patch. Any idea why? Perhaps a
full invalidation is occurring for some reason in the layout test?
> 
> Try using text-based-repaint.js instead, it should be simpler and more
reliable. Also, please put the test in paint/invalidation/. There are several
tests in that directory that look for invalidations using text-based-repaint.js.

Thanks, this worked. It clearly shows the invalidation on the scrolling contents
layer.

[chrishtr, 2016-08-11 15:00:23]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-08-11 15:00:23]

lgtm

[commit-bot: I haz the power, 2016-08-11 15:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 16:22:42]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[flackr, 2016-08-11 19:13:57]

Can you take a look at the latest patch. I didn't realize I hadn't been running
with asserts but we need to invalidate the entire scrolling contents layer
(though perhaps with careful thought we could invalidate less based on the
invalidation rect? See my comment in the TODO).

[chrishtr, 2016-08-11 20:27:29]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-08-11 20:27:29]

lgtm

[commit-bot: I haz the power, 2016-08-11 20:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:36:50]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-11 23:38:31]

Description was changed from

==========
Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to
invalidate
appropriately when those backgrounds change.

BUG=636437
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Invalidate scrolling contents layer on background invalidations painted into it.

When we paint backgrounds into the scrolling contents layer we need to
invalidate
appropriately when those backgrounds change.

BUG=636437
TEST=compositing/overflow/overflow-scroll-with-local-background-invalidation.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f
Cr-Commit-Position: refs/heads/master@{#411441}
==========

[commit-bot: I haz the power, 2016-08-11 23:38:33]

Patchset 3 (id:??) landed as
https://crrev.com/c01760bc132fcc6a8d96b1d567bad36a6614677f
Cr-Commit-Position: refs/heads/master@{#411441}