Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2235843002: Clean up CPDF_HintTables::LoadHintStream a little. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up CPDF_HintTables::LoadHintStream a little. - Return earlier when possible. - Fail rather than crash on invalid values. Committed: https://pdfium.googlesource.com/pdfium/+/d83842e0b9ef6e25ab28642e2a146159ac9f3596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
PTAL
4 years, 4 months ago (2016-08-10 17:29:50 UTC) #7
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-10 17:32:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235843002/1
4 years, 4 months ago (2016-08-10 17:33:42 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:33:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d83842e0b9ef6e25ab28642e2a146159ac9f...

Powered by Google App Engine
This is Rietveld 408576698