Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2235833003: Adjust CSP of feedback extension (Closed)

Created:
4 years, 4 months ago by Sergey Shekyan
Modified:
4 years, 4 months ago
Reviewers:
jww, Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust CSP of feedback extension Recent change to Content Security Policy matching algorithm for "*" source-expression at https://codereview.chromium.org/2209113002/ requires to adjust policies, that use "*" and assume that it will match resource loads from schemes other than http/https/ws/wss. Two extension manifests had to be changed, becasue they expect resources to load from `file:` and `chrome:` and are using "*", which was addressed in CL mentioned above. Unfortunately, I forgot to update style-src directive to also allow resources from `chrome:` scheme. This patch set fixes that. BUG=633044 R=jww@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0e84bb1695f941cb15c99abc51970db0c65dc910 Cr-Commit-Position: refs/heads/master@{#411189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/feedback/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
jww
On 2016/08/10 21:30:08, Sergey Shekyan wrote: > Description was changed from > > ========== > ...
4 years, 4 months ago (2016-08-10 22:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235833003/1
4 years, 4 months ago (2016-08-10 22:52:22 UTC) #5
jww
thestig@chromium.org: Can you owner review? Thanks!
4 years, 4 months ago (2016-08-10 22:54:27 UTC) #7
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-10 22:59:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 23:52:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:54:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e84bb1695f941cb15c99abc51970db0c65dc910
Cr-Commit-Position: refs/heads/master@{#411189}

Powered by Google App Engine
This is Rietveld 408576698