Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 223583002: Revert of Make DevTools support for the embedded SharedWorker. (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Make DevTools support for the embedded SharedWorker. (https://codereview.chromium.org/196503005/) Reason for revert: buildbot failure in Chromium Memory on Linux ASan+LSan Tests SharedWorkerDevToolsManagerTest.AttachTest test causes memory leaks. Original issue's description: > Make DevTools support for the embedded SharedWorker. > > BUG=327256 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261314 TBR=kinuko@chromium.org,pfeldman@chromium.org,yurys@chromium.org,sergeyv@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -792 lines) Patch
D content/browser/devtools/shared_worker_devtools_manager.h View 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/devtools/shared_worker_devtools_manager.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D content/browser/devtools/shared_worker_devtools_manager_unittest.cc View 1 chunk +0 lines, -263 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 5 chunks +10 lines, -34 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 3 chunks +5 lines, -12 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 7 chunks +16 lines, -84 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
horo
Created Revert of Make DevTools support for the embedded SharedWorker.
6 years, 8 months ago (2014-04-03 08:52:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/223583002/1
6 years, 8 months ago (2014-04-03 08:52:48 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 08:54:04 UTC) #3
Message was sent while issue was closed. 
Change committed as 261327

Powered by Google App Engine
This is Rietveld 408576698