Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2235823002: [layoutng] Add a basic unit test for NGBlockLayoutAlgorithm (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add a basic unit test for NGBlockLayoutAlgorithm R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 NOTRY=true Committed: https://crrev.com/10f25d0ee6a3072e4089e0c5bbe5ba0c2fcd2b55 Cr-Commit-Position: refs/heads/master@{#411155}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename to _test #

Patch Set 3 : Rebased #

Patch Set 4 : fix compile error #

Patch Set 5 : Have to mark StyleBoxData as CORE_EXPORT for the test to link #

Patch Set 6 : One more try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 33 (22 generated)
cbiesinger
4 years, 4 months ago (2016-08-10 15:51:52 UTC) #1
eae
LGTM w/nits Also s/unittest/test/ https://codereview.chromium.org/2235823002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_unittest.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_unittest.cc (right): https://codereview.chromium.org/2235823002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_unittest.cc#newcode28 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_unittest.cc:28: NGConstraintSpace space(LayoutUnit(100), LayoutUnit(-1)); For abs-pos ...
4 years, 4 months ago (2016-08-10 15:55:19 UTC) #4
cbiesinger
On 2016/08/10 15:55:19, eae wrote: > NGConstraintSpace space(LayoutUnit(100), LayoutUnit(-1)); > For abs-pos we need the ...
4 years, 4 months ago (2016-08-10 19:02:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235823002/40001
4 years, 4 months ago (2016-08-10 19:02:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235823002/60001
4 years, 4 months ago (2016-08-10 19:08:54 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/138583)
4 years, 4 months ago (2016-08-10 19:40:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235823002/80001
4 years, 4 months ago (2016-08-10 20:03:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235823002/100001
4 years, 4 months ago (2016-08-10 20:16:30 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235823002/100001
4 years, 4 months ago (2016-08-10 21:53:54 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-10 21:58:23 UTC) #31
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 22:00:00 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/10f25d0ee6a3072e4089e0c5bbe5ba0c2fcd2b55
Cr-Commit-Position: refs/heads/master@{#411155}

Powered by Google App Engine
This is Rietveld 408576698