MD History: Add tooltip for history menu button

MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a
Cr-Commit-Position: refs/heads/master@{#413042}

[lshang, 2016-08-11 01:18:59]

Description was changed from

==========
MD History: Add tooltip for history menu button

BUG=
==========

to

==========
MD History: Add tooltip for history menu button

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[lshang, 2016-08-11 01:40:45]

Description was changed from

==========
MD History: Add tooltip for history menu button

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also
use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[lshang, 2016-08-11 01:42:22]

lshang@chromium.org changed reviewers:
+ dbeam@chromium.org, tsergeant@chromium.org

[lshang, 2016-08-11 01:42:23]

PTAL thanks!

[lshang, 2016-08-12 04:20:03]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 04:20:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 05:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 05:38:34]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-08-15 03:02:47]

https://codereview.chromium.org/2235803003/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2235803003/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:461: +      <message
name="IDS_MD_HISTORY_HISTORY_MENU_DESCRIPTION" desc="Text used to identify the
history sidebar menu button for screen readers.">
You can probably just say that it's a tooltip, rather than specifically
mentioning screen readers.

https://codereview.chromium.org/2235803003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js (right):

https://codereview.chromium.org/2235803003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js:19: buttonLabel: String,
How about calling this `menuLabel`? buttonLabel could apply to any button in the
toolbar.

[lshang, 2016-08-15 05:39:10]

https://codereview.chromium.org/2235803003/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2235803003/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:461: +      <message
name="IDS_MD_HISTORY_HISTORY_MENU_DESCRIPTION" desc="Text used to identify the
history sidebar menu button for screen readers.">
On 2016/08/15 03:02:47, tsergeant wrote:
> You can probably just say that it's a tooltip, rather than specifically
> mentioning screen readers.

Done.

https://codereview.chromium.org/2235803003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js (right):

https://codereview.chromium.org/2235803003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js:19: buttonLabel: String,
On 2016/08/15 03:02:47, tsergeant wrote:
> How about calling this `menuLabel`? buttonLabel could apply to any button in
the
> toolbar.

Done.

[tsergeant, 2016-08-15 06:23:32]

lgtm

https://codereview.chromium.org/2235803003/diff/60001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2235803003/diff/60001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:212: <message
name="IDS_SETTINGS_MENU_BUTTON_LABEL" desc="Text used to identify the sidebar
menu button for screen readers.">
Nit: Make the same change here as well.

[lshang, 2016-08-17 00:55:04]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 00:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-08-17 00:58:41]

Kindly ping @dbeam~ :-)

https://codereview.chromium.org/2235803003/diff/60001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2235803003/diff/60001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:212: <message
name="IDS_SETTINGS_MENU_BUTTON_LABEL" desc="Text used to identify the sidebar
menu button for screen readers.">
On 2016/08/15 06:23:32, tsergeant wrote:
> Nit: Make the same change here as well.

Done.

[Dan Beam, 2016-08-17 02:07:01]

lgtm i suppose

but "Menu" is a pretty bad description... did you get this suggestion from
somebody?

[commit-bot: I haz the power, 2016-08-17 02:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 02:47:43]

Dry run: This issue passed the CQ dry run.

[lshang, 2016-08-17 06:11:13]

On 2016/08/17 02:07:01, Dan Beam wrote:
> lgtm i suppose
> 
> but "Menu" is a pretty bad description... did you get this suggestion from
> somebody?

No(⊙＿⊙)...I just thought since it's the tooltip of **menu** button and the icon
is also called "menu"...and it's very simple:P

Do you have other suggestions?

[lshang, 2016-08-17 06:16:22]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 06:16:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 07:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 07:09:55]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-17 18:31:19]

On 2016/08/17 06:11:13, Liu Shang wrote:
> On 2016/08/17 02:07:01, Dan Beam wrote:
> > lgtm i suppose
> > 
> > but "Menu" is a pretty bad description... did you get this suggestion from
> > somebody?
> 
> No(⊙＿⊙)...I just thought since it's the tooltip of **menu** button and the
icon
> is also called "menu"...and it's very simple:P
> 
> Do you have other suggestions?

Maybe something along the lines of what the button would do more specifically,
like "Show navigation" (at least for settings)

I'll ask the PM we've been working with, tbuckley, for his thoughts as well.

[lshang, 2016-08-18 08:18:20]

On 2016/08/17 18:31:19, Dan Beam wrote:
> On 2016/08/17 06:11:13, Liu Shang wrote:
> > On 2016/08/17 02:07:01, Dan Beam wrote:
> > > lgtm i suppose
> > > 
> > > but "Menu" is a pretty bad description... did you get this suggestion from
> > > somebody?
> > 
> > No(⊙＿⊙)...I just thought since it's the tooltip of **menu** button and the
> icon
> > is also called "menu"...and it's very simple:P
> > 
> > Do you have other suggestions?
> 
> Maybe something along the lines of what the button would do more specifically,
> like "Show navigation" (at least for settings)
> 
> I'll ask the PM we've been working with, tbuckley, for his thoughts as well.

OK, waiting for his feedback:-)

[Dan Beam, 2016-08-18 19:24:54]

On 2016/08/18 08:18:20, Liu Shang wrote:
> On 2016/08/17 18:31:19, Dan Beam wrote:
> > On 2016/08/17 06:11:13, Liu Shang wrote:
> > > On 2016/08/17 02:07:01, Dan Beam wrote:
> > > > lgtm i suppose
> > > > 
> > > > but "Menu" is a pretty bad description... did you get this suggestion
from
> > > > somebody?
> > > 
> > > No(⊙＿⊙)...I just thought since it's the tooltip of **menu** button and the
> > icon
> > > is also called "menu"...and it's very simple:P
> > > 
> > > Do you have other suggestions?
> > 
> > Maybe something along the lines of what the button would do more
specifically,
> > like "Show navigation" (at least for settings)
> > 
> > I'll ask the PM we've been working with, tbuckley, for his thoughts as well.
> 
> OK, waiting for his feedback:-)

he says "Main menu".  not much better.  whatevs.

[lshang, 2016-08-19 01:24:29]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 01:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 03:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 03:02:58]

Dry run: This issue passed the CQ dry run.

[lshang, 2016-08-19 03:08:56]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-08-19 03:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2235803003/#ps120001
(title: "minor change in menu label text")

[commit-bot: I haz the power, 2016-08-19 03:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 03:13:30]

Description was changed from

==========
MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also
use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also
use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-19 03:13:33]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-19 03:18:52]

Description was changed from

==========
MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also
use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add tooltip for history menu button

Add tooltip for toolbar menu button in MD history, and MD settings which also
use
<cr-toolbar>.

BUG=633556
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a
Cr-Commit-Position: refs/heads/master@{#413042}
==========

[commit-bot: I haz the power, 2016-08-19 03:18:53]

Patchset 7 (id:??) landed as
https://crrev.com/874ed7b5e521c6cf2687b7f12dc09c44f48f206a
Cr-Commit-Position: refs/heads/master@{#413042}