Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2235793002: MD Settings: remove appeal and (Coming soon) (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove appeal and (Coming soon) R=hcarmona@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3414cf418dfee42efe99be0d5551d3e1e0ad9524 Cr-Commit-Position: refs/heads/master@{#411147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 3 chunks +2 lines, -44 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Dan Beam
4 years, 4 months ago (2016-08-10 14:54:38 UTC) #2
hcarmona
lgtm
4 years, 4 months ago (2016-08-10 14:56:54 UTC) #3
Dan Beam
* dbeam pours one out for these UIs
4 years, 4 months ago (2016-08-10 16:17:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235793002/1
4 years, 4 months ago (2016-08-10 16:17:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/271003)
4 years, 4 months ago (2016-08-10 18:07:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235793002/1
4 years, 4 months ago (2016-08-10 19:02:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 21:11:24 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:13:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3414cf418dfee42efe99be0d5551d3e1e0ad9524
Cr-Commit-Position: refs/heads/master@{#411147}

Powered by Google App Engine
This is Rietveld 408576698