third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp - Issue 2235753003: [DevTools] Older V8 compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2235753003: [DevTools] Older V8 compatibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

index dde37c85e52aa4d2ca6e239292e85c23a0cee2b9..a7ebd019f9490300df3aefa6b9c45d5a0535bab8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

@@ -250,7 +250,7 @@ void V8Debugger::breakProgram()

v8::HandleScope scope(m_isolate);

v8::Local<v8::Function> breakFunction;

- if (!v8::Function::New(m_isolate->GetCurrentContext(), &V8Debugger::breakProgramCallback, v8::External::New(m_isolate, this), 0, v8::ConstructorBehavior::kThrow).ToLocal(&breakFunction))

+ if (!V8_FUNCTION_NEW_REMOVE_PROTOTYPE(m_isolate->GetCurrentContext(), &V8Debugger::breakProgramCallback, v8::External::New(m_isolate, this), 0).ToLocal(&breakFunction))

return;

v8::Debug::Call(debuggerContext(), breakFunction).ToLocalChecked();

}