Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2235753003: [DevTools] Older V8 compatibility (Closed)

Created:
4 years, 4 months ago by eostroukhov
Modified:
4 years, 4 months ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Older V8 compatibility Change to make V8 inspector compatible with older V8 versions, like the one used in Node 6.x. BUG= Committed: https://crrev.com/8984baba5f8c2a6a0a96f1150d9c5ad7f7db027b Cr-Commit-Position: refs/heads/master@{#411140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8Compat.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
eostroukhov
4 years, 4 months ago (2016-08-10 18:14:56 UTC) #3
eostroukhov
Please consider :)
4 years, 4 months ago (2016-08-10 18:15:11 UTC) #4
dgozman
I defer to Alexey here.
4 years, 4 months ago (2016-08-10 18:39:24 UTC) #6
kozy
lgtm
4 years, 4 months ago (2016-08-10 18:50:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235753003/1
4 years, 4 months ago (2016-08-10 18:50:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/259432)
4 years, 4 months ago (2016-08-10 19:21:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235753003/1
4 years, 4 months ago (2016-08-10 19:37:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 20:59:40 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:01:03 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8984baba5f8c2a6a0a96f1150d9c5ad7f7db027b
Cr-Commit-Position: refs/heads/master@{#411140}

Powered by Google App Engine
This is Rietveld 408576698