Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2235733003: Added some missing java files to android_protobuf/BUILD.gn (Closed)

Created:
4 years, 4 months ago by bajones
Modified:
4 years, 4 months ago
Reviewers:
nyquist, Colin Meek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added some missing java files to android_protobuf/BUILD.gn Including these files is necessary in order to satisfy dependencies in gvr-android-sdk. BUG=389343 Committed: https://crrev.com/1e25d54f49c265b7e445a344fc396b33645a5b22 Cr-Commit-Position: refs/heads/master@{#411112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/android_protobuf/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bajones
meek@ or nyquist@, PTAL!
4 years, 4 months ago (2016-08-10 16:34:21 UTC) #2
nyquist
lgtm
4 years, 4 months ago (2016-08-10 16:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235733003/1
4 years, 4 months ago (2016-08-10 17:06:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 19:08:16 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:10:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e25d54f49c265b7e445a344fc396b33645a5b22
Cr-Commit-Position: refs/heads/master@{#411112}

Powered by Google App Engine
This is Rietveld 408576698