third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py - Issue 2235703003: [DevTools] Remove Map usage from InjectedScriptSource.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py

Issue 2235703003: [DevTools] Remove Map usage from InjectedScriptSource.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py

diff --git a/third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py b/third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py

index c3da9aac714487ce9e5a65488afd31ef65d1acae..9a220bca1772eafea4c228587e22b2158e09047e 100755

--- a/third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py

+++ b/third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py

@@ -49,7 +49,7 @@ def validate_injected_script(fileName):

global_functions = "|".join([

"eval", "uneval", "isFinite", "isNaN", "parseFloat", "parseInt", "decodeURI", "decodeURIComponent",

- "encodeURI", "encodeURIComponent", "escape", "unescape",

+ "encodeURI", "encodeURIComponent", "escape", "unescape", "Map", "Set"

])

# Black list:

@@ -63,7 +63,7 @@ def validate_injected_script(fileName):

errors_found = False

for i, line in enumerate(lines):

- if line.find("suppressBlacklist"):

+ if line.find("suppressBlacklist") != -1:

continue

for match in re.finditer(black_list_call_regex, line):

errors_found = True