[DevTools] Remove Map usage from InjectedScriptSource.js

third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 42 matching lines @@
         array[array.length] = arguments[i];
 }
 
 /**
  * @param {*} obj
  * @return {string}
  * @suppress {uselessCode}
  */
 function toString(obj)
 {
-    // We don't use String(obj) because String16 could be overridden.
+    // We don't use String(obj) because String could be overridden.
     // Also the ("" + obj) expression may throw.
     try {
         return "" + obj;
     } catch (e) {
         var name = InjectedScriptHost.internalConstructorName(obj) || InjectedScriptHost.subtype(obj) || (typeof obj);
         return "#<" + name + ">";
     }
 }
 
 /**
@@ skipping 90 matching lines @@
 
 /**
  * @param {!Object} object
  * @param {string} attribute
  * @return {boolean}
  */
 function doesAttributeHaveObservableSideEffectOnGet(object, attribute)
 {
     for (var interfaceName in domAttributesWithObservableSideEffectOnGet) {
         var interfaceFunction = inspectedGlobalObject[interfaceName];
-        var isInstance = typeof interfaceFunction === "function" && object instanceof interfaceFunction;
+        // instanceof call looks safe after typeof check.
+        var isInstance = typeof interfaceFunction === "function" && /* suppressBlacklist */ object instanceof interfaceFunction;
         if (isInstance)
             return attribute in domAttributesWithObservableSideEffectOnGet[interfaceName];
     }
     return false;
 }
 
 /**
  * @constructor
  */
 var InjectedScript = function()
 {
 }
 
 /**
  * @type {!Object.<string, boolean>}
  * @const
  */
 InjectedScript.primitiveTypes = {
     "undefined": true,
     "boolean": true,
     "number": true,
     "string": true,
     __proto__: null
 }
 
 /**
- * @type {!Map<string, string>}
+ * @type {!Object<string, string>}
  * @const
  */
-InjectedScript.closureTypes = new Map([
-    ["local", "Local"],
-    ["closure", "Closure"],
-    ["catch", "Catch"],
-    ["block", "Block"],
-    ["script", "Script"],
-    ["with", "With Block"],
-    ["global", "Global"]
-]);
+InjectedScript.closureTypes = { __proto__: null };
+InjectedScript.closureTypes["local"] = "Local";
+InjectedScript.closureTypes["closure"] = "Closure";
+InjectedScript.closureTypes["catch"] = "Catch";
+InjectedScript.closureTypes["block"] = "Block";
+InjectedScript.closureTypes["script"] = "Script";
+InjectedScript.closureTypes["with"] = "With Block";
+InjectedScript.closureTypes["global"] = "Global";
 
 InjectedScript.prototype = {
     /**
      * @param {*} object
      * @return {boolean}
      */
     isPrimitiveValue: function(object)
     {
         // FIXME(33716): typeof document.all is always 'undefined'.
         return InjectedScript.primitiveTypes[typeof object] && !this._isHTMLAllCollection(object);
@@ skipping 407 matching lines @@
             if (typeof obj.length === "number")
                 className += "[" + obj.length + "]";
             return className;
         }
 
         if (typeof obj === "function")
             return toString(obj);
 
         if (isSymbol(obj)) {
             try {
-                return obj.toString() || "Symbol";
+                // It isn't safe, because Symbol.prototype.toString can be overriden.
+                return /* suppressBlacklist */ obj.toString() || "Symbol";
             } catch (e) {
                 return "Symbol";
             }
         }
 
         if (InjectedScriptHost.subtype(obj) === "error") {
             try {
                 var stack = obj.stack;
                 var message = obj.message && obj.message.length ? ": " + obj.message : "";
                 var firstCallFrame = /^\s+at\s/m.exec(stack);
@@ skipping 10 matching lines @@
         if (subtype === "internal#entry") {
             if ("key" in obj)
                 return "{" + this._describeIncludingPrimitives(obj.key) + " => " + this._describeIncludingPrimitives(obj.value) + "}";
             return this._describeIncludingPrimitives(obj.value);
         }
 
         if (subtype === "internal#scopeList")
             return "Scopes[" + obj.length + "]";
 
         if (subtype === "internal#scope")
-            return (InjectedScript.closureTypes.get(obj.type) || "Unknown") + (obj.name ? " (" + obj.name + ")" : "");
+            return (InjectedScript.closureTypes[obj.type] || "Unknown") + (obj.name ? " (" + obj.name + ")" : "");
 
         return className;
     },
 
     /**
      * @param {*} value
      * @return {string}
      */
     _describeIncludingPrimitives: function(value)
     {
@@ skipping 104 matching lines @@
      * @param {*=} customObjectConfig
      * @return {?RuntimeAgent.CustomPreview}
      */
     _customPreview: function(object, objectGroupName, customObjectConfig)
     {
         /**
          * @param {!Error} error
          */
         function logError(error)
         {
-            Promise.resolve().then(inspectedGlobalObject.console.error.bind(inspectedGlobalObject.console, "Custom Formatter Failed: " + error.message));
+            // We use user code to generate custom output for object, we can use user code for reporting error too.
+            Promise.resolve().then(/* suppressBlacklist */ inspectedGlobalObject.console.error.bind(inspectedGlobalObject.console, "Custom Formatter Failed: " + error.message));
         }
 
         /**
          * @suppressReceiverCheck
          * @param {*} object
          * @param {*=} customObjectConfig
          * @return {*}
          */
         function wrap(object, customObjectConfig)
         {
@@ skipping 258 matching lines @@
             return string.substr(0, leftHalf) + "\u2026" + string.substr(string.length - rightHalf, rightHalf);
         }
         return string.substr(0, maxLength) + "\u2026";
     },
 
     __proto__: null
 }
 
 return injectedScript;
 })