Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2235703003: [DevTools] Remove Map usage from InjectedScriptSource.js (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove Map usage from InjectedScriptSource.js .. and fixed injected script validation script. BUG=636409 R=dgozman@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/6753edc190cc71b16f0f930848a7ff8825457152 Cr-Commit-Position: refs/heads/master@{#411109}

Patch Set 1 #

Total comments: 2

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M third_party/WebKit/Source/devtools/scripts/check_injected_script_source.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 6 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-10 16:43:37 UTC) #2
dgozman
https://codereview.chromium.org/2235703003/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/2235703003/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js#newcode204 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:204: InjectedScript.closureTypes = {}; __proto__: null
4 years, 4 months ago (2016-08-10 16:48:36 UTC) #4
kozy
all done! https://codereview.chromium.org/2235703003/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/2235703003/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js#newcode204 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:204: InjectedScript.closureTypes = {}; On 2016/08/10 16:48:36, dgozman ...
4 years, 4 months ago (2016-08-10 17:02:43 UTC) #6
dgozman
lgtm
4 years, 4 months ago (2016-08-10 17:07:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235703003/40001
4 years, 4 months ago (2016-08-10 17:27:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-10 18:52:11 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:55:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6753edc190cc71b16f0f930848a7ff8825457152
Cr-Commit-Position: refs/heads/master@{#411109}

Powered by Google App Engine
This is Rietveld 408576698