Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2235643002: Code cleanup related to unified text checker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableUnifiedTextCheckerByDefault
Patch Set: Rebased on removal of grammar-checking code Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
index e9cfa440657530f48083a9617082b4fde0a41c9f..4fc0419320bac2ef0424aafae404535c2e0cf213 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
@@ -61,11 +61,7 @@ public:
static bool isSpellCheckingEnabledFor(const VisibleSelection&);
void markMisspellingsAfterLineBreak(const VisibleSelection& wordSelection);
void markMisspellingsAfterTypingToWord(const VisiblePosition &wordStart, const VisibleSelection& selectionAfterTyping);
- bool markMisspellings(const VisibleSelection&);
- void markBadGrammar(const VisibleSelection&);
- void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, const VisibleSelection& grammarSelection);
void markAndReplaceFor(SpellCheckRequest*, const Vector<TextCheckingResult>&);
- void markAllMisspellingsAndBadGrammarInRanges(const EphemeralRange& spellingRange, const EphemeralRange& grammarRange);
void advanceToNextMisspelling(bool startBeforeSelection = false);
void showSpellingGuessPanel();
void didBeginEditing(Element*);
@@ -76,7 +72,6 @@ public:
void removeSpellingMarkers();
void removeSpellingMarkersUnderWords(const Vector<String>& words);
void spellCheckAfterBlur();
- void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
void didEndEditingOnTextField(Element*);
bool selectionStartHasMarkerFor(DocumentMarker::MarkerType, int from, int length) const;
@@ -106,12 +101,11 @@ private:
return *m_frame;
}
- bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
-
void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
- bool unifiedTextCheckerEnabled() const;
void chunkAndMarkAllMisspellingsAndBadGrammar(const TextCheckingParagraph& fullParagraphToCheck);
+ void markAllMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, const VisibleSelection& grammarSelection);
+ void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
Member<LocalFrame> m_frame;
const Member<SpellCheckRequester> m_spellCheckRequester;

Powered by Google App Engine
This is Rietveld 408576698