third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-crash.html - Issue 2235643002: Code cleanup related to unified text checker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-crash.html

Issue 2235643002: Code cleanup related to unified text checker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableUnifiedTextCheckerByDefault

Patch Set: Rebased on removal of grammar-checking code Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync.html ('k') | third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <p>Make sure spell checker attempts to spell check uneditable text "Bob".</p>	4 <p>Make sure spell checker attempts to spell check uneditable text "Bob".</p>

5 <div id="edit" contenteditable="true"><span contenteditable="false">Bob</span> ; <span contenteditable="false"></span></div>	5 <div id="edit" contenteditable="true"><span contenteditable="false">Bob</span> ; <span contenteditable="false"></span></div>

6 <div id="log"></div>	6 <div id="log"></div>

7 <script>	7 <script>

8 test(function() {	8 test(function() {

9 if (window.internals)

10 internals.settings.setUnifiedTextCheckerEnabled(true);

11 var text = edit.childNodes[1];	9 var text = edit.childNodes[1];

12 var selection = window.getSelection();	10 var selection = window.getSelection();

13 selection.collapse(text, text.length);	11 selection.collapse(text, text.length);

14 // Trigger spell checking	12 // Trigger spell checking

15 selection.modify('move', 'right', 'character');	13 selection.modify('move', 'right', 'character');

16 });	14 });

17 </script>	15 </script>

OLD	NEW