third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html - Issue 2235643002: Code cleanup related to unified text checker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html

Issue 2235643002: Code cleanup related to unified text checker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnableUnifiedTextCheckerByDefault

Patch Set: Rebased on removal of grammar-checking code Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/grammar.html ('k') | third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <title>Editing a grammatically-incorrect word</title>	5 <title>Editing a grammatically-incorrect word</title>

6 </head>	6 </head>

7 <body>	7 <body>

8 <div id="src" contenteditable="true" spellcheck="true"></div><br/>	8 <div id="src" contenteditable="true" spellcheck="true"></div><br/>

9 <script language="javascript">	9 <script language="javascript">

10 description('Test if WebKit removes grammar markers when we edit a grammatically -incorrect word. '	10 description('Test if WebKit removes grammar markers when we edit a grammatically -incorrect word. '

11 + 'To test manually, type a grammatically-incorrect sentence "You has the ri ght." and type '	11 + 'To test manually, type a grammatically-incorrect sentence "You has the ri ght." and type '

12 + 'a backspace key to delete the last character of "has". '	12 + 'a backspace key to delete the last character of "has". '

13 + 'This test succeeds when "ha" does not have grammar markers.');	13 + 'This test succeeds when "ha" does not have grammar markers.');

14	14

15 jsTestIsAsync = true;	15 jsTestIsAsync = true;

16	16

17 if (window.internals)

18 internals.settings.setUnifiedTextCheckerEnabled(true);

19

20 function editAndCheckSentence()	17 function editAndCheckSentence()

21 {	18 {

22 // Delete the end of this sentence until it becomes "You ha".	19 // Delete the end of this sentence until it becomes "You ha".

23 for (var i = 0; i < 12; ++i)	20 for (var i = 0; i < 12; ++i)

24 testRunner.execCommand("DeleteBackward");	21 testRunner.execCommand("DeleteBackward");

25	22

26 shouldBecomeEqual('internals.hasGrammarMarker(document, 4, 2)', 'false', fin ishJSTest);	23 shouldBecomeEqual('internals.hasGrammarMarker(document, 4, 2)', 'false', fin ishJSTest);

27 }	24 }

28	25

29 var target = document.getElementById('src');	26 var target = document.getElementById('src');

30 target.focus();	27 target.focus();

31 document.execCommand("InsertText", false, "You has the right.");	28 document.execCommand("InsertText", false, "You has the right.");

32	29

33 if (window.internals)	30 if (window.internals)

34 shouldBecomeEqual('internals.hasGrammarMarker(document, 4, 3)', 'true', edit AndCheckSentence);	31 shouldBecomeEqual('internals.hasGrammarMarker(document, 4, 3)', 'true', edit AndCheckSentence);

35 </script>	32 </script>

36 </body>	33 </body>

37 </html>	34 </html>

OLD	NEW