Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2235623003: cc: Add gfx::ColorSpace to cc::ResourceProvider resource creation (Closed)

Created:
4 years, 4 months ago by ccameron
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add gfx::ColorSpace to cc::ResourceProvider resource creation Updated all callers to specify a color space. Almost all of these are the default gfx::ColorSpace, but some of them in cc::DirectRenderer and its subclasses use the cc::OutputSurface's color space, as appropriate. Update tests for cc::ResourcePool to take color space into account for resource recycling. Add tests for plumbing through to queryable properts in locks. The addition of this argument does not change any behaviors, and this patch should have no observable effects. BUG=44872 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b4d9236157069f52950e8f4d84cbc0f0df5cd9ca Cr-Commit-Position: refs/heads/master@{#411575}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -148 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M cc/output/output_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 9 chunks +19 lines, -10 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/resource.h View 2 chunks +7 lines, -4 lines 0 comments Download
M cc/resources/resource_pool.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/resources/resource_pool.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M cc/resources/resource_pool_unittest.cc View 8 chunks +36 lines, -11 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/resources/resource_provider.cc View 4 chunks +26 lines, -17 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 33 chunks +84 lines, -45 lines 0 comments Download
M cc/resources/scoped_resource.h View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/resources/scoped_resource.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M cc/resources/scoped_resource_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M cc/test/fake_ui_resource_layer_tree_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M cc/tiles/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/color_space.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/color_space.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ccameron
Lots of plumbing, has no effect on the running code. Couple of tests to make ...
4 years, 4 months ago (2016-08-10 21:24:01 UTC) #5
ccameron
ping -- does this look reasonable?
4 years, 4 months ago (2016-08-11 22:41:22 UTC) #8
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-11 22:45:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235623003/20001
4 years, 4 months ago (2016-08-12 06:34:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 07:33:41 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:35:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4d9236157069f52950e8f4d84cbc0f0df5cd9ca
Cr-Commit-Position: refs/heads/master@{#411575}

Powered by Google App Engine
This is Rietveld 408576698