Issue 22356003: Revert 215772 "Don't assume that widgets of TYPE_CONTROL are par..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22356003: Revert 215772 "Don't assume that widgets of TYPE_CONTROL are par..." (Closed)

Created:
7 years, 4 months ago by kochi

Modified:
7 years, 4 months ago

Reviewers:
zturner

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 215772 "Don't assume that widgets of TYPE_CONTROL are par..." > Don't assume that widgets of TYPE_CONTROL are parented to the RootWindow. > This was causing the SadTabView to be drawn at the wrong origin. > > BUG=262051 > > Review URL: https://chromiumcodereview.appspot.com/21504003 TBR=zturner@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215792

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -45 lines)			Patch
	M	trunk/src/ui/views/widget/desktop_aura/desktop_screen_position_client.cc	View		1 chunk	+7 lines, -4 lines	0 comments	Download
	M	trunk/src/ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc	View		1 chunk	+0 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kochi

7 years, 4 months ago (2013-08-06 05:34:36 UTC) #3

Hi,
the CL caused constant failure in win8_aura bot.  Could you look at it?

DesktopScreenPositionClientTest.PositionControlWithNonRootParent:
[3328:2948:0805/205111:1148994:ERROR:desktop_root_window_host_win.cc(716)]
NOT IMPLEMENTED
c:\b\build\slave\win_aura_builder\build\src\ui\views\widget\desktop_aura\desktop_screen_position_client_unittest.cc(75):
error: Value of: actual_bounds.ToString()
Actual: "51,74 500x400"
Expected: expected_bounds.ToString()
Which is: "48,48 500x400"




On Tue, Aug 6, 2013 at 1:29 PM, <kochi@chromium.org> wrote:

> Committed patchset #1 manually as r215792.
>
>
https://codereview.chromium.**org/22356003/<https://codereview.chromium.org/2...
>



-- 
Takayoshi Kochi

Expand Messages | Collapse Messages