Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2235583003: Convert ContextBuilder to use FolderBasedSdk (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 3 chunks +5 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 2 chunks +14 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This also fixes the bug you found earlier and has the side-effect that creating a ...
4 years, 4 months ago (2016-08-10 21:16:33 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2235583003/diff/1/pkg/analyzer/test/src/context/mock_sdk.dart File pkg/analyzer/test/src/context/mock_sdk.dart (right): https://codereview.chromium.org/2235583003/diff/1/pkg/analyzer/test/src/context/mock_sdk.dart#newcode29 pkg/analyzer/test/src/context/mock_sdk.dart:29: '/lib/async/async.dart', We might want to use different paths ...
4 years, 4 months ago (2016-08-10 21:25:43 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2235583003/diff/1/pkg/analyzer/test/src/context/mock_sdk.dart File pkg/analyzer/test/src/context/mock_sdk.dart (right): https://codereview.chromium.org/2235583003/diff/1/pkg/analyzer/test/src/context/mock_sdk.dart#newcode29 pkg/analyzer/test/src/context/mock_sdk.dart:29: '/lib/async/async.dart', I thought about that, then forgot. Done.
4 years, 4 months ago (2016-08-10 21:41:33 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-08-10 21:56:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1c6e950547d1d796ba539836dbfb923631bf517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698