Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 2235573002: Fix OfflinePageDownloadBridge. Calls native->Java did not work due to missed JNI initialization. (Closed)

Created:
4 years, 4 months ago by Dmitry Titov
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OfflinePageDownloadBridge. Calls native->Java did not work due to missed JNI initialization. BUG=630817 Committed: https://crrev.com/c36e6e41cb0c8ba0da3791cfbd42cfbd3601365c Cr-Commit-Position: refs/heads/master@{#410923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Dmitry Titov
Here is why OnItemsLoaded was not fired... I now see offline pages in Download UI! ...
4 years, 4 months ago (2016-08-10 01:04:42 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-10 01:07:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235573002/1
4 years, 4 months ago (2016-08-10 01:17:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 02:14:56 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 02:16:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c36e6e41cb0c8ba0da3791cfbd42cfbd3601365c
Cr-Commit-Position: refs/heads/master@{#410923}

Powered by Google App Engine
This is Rietveld 408576698