pkg/barback/test/transformer/bad.dart - Issue 223553008: Only pass an AssetId to isPrimary and declareOutputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/test/transformer/bad.dart

Issue 223553008: Only pass an AssetId to isPrimary and declareOutputs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fixes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/barback/test/package_graph/transform/pass_through_test.dart ('K') | « pkg/barback/test/package_graph/transform/pass_through_test.dart ('k') | pkg/barback/test/transformer/bad_log.dart » ('j') | samples/third_party/dromaeo/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/barback/test/transformer/bad.dart

diff --git a/pkg/barback/test/transformer/bad.dart b/pkg/barback/test/transformer/bad.dart

index 49046ca5b45aed5e05dda27f5de0121ecd6aac9a..11b61cc0d8bd0f334251a955e5af35183bb4f706 100644

--- a/pkg/barback/test/transformer/bad.dart

+++ b/pkg/barback/test/transformer/bad.dart

@@ -22,7 +22,7 @@ class BadTransformer extends MockTransformer {

BadTransformer(this.outputs);

- Future<bool> doIsPrimary(Asset asset) => new Future.value(true);

+ Future<bool> doIsPrimary(_) => new Future.value(true);

Bob Nystrom 2014/04/03 22:28:29 I'd prefer the full "AssetId id" here even though

nweiz 2014/04/03 23:03:50 Done.

Future doApply(Transform transform) {

return newFuture(() {