Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: ash/common/shelf/wm_shelf.h

Issue 2235513002: mash shelf: Don't create shelf DimmerView in ShelfWidget on mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaks Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/shelf/wm_dimmer_view.h ('k') | ash/mus/bridge/wm_shelf_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/wm_shelf.h
diff --git a/ash/common/shelf/wm_shelf.h b/ash/common/shelf/wm_shelf.h
index 841679f1669c534d4a7292d29580e24a5634606f..df9f5c18d3a36c5b0bf7d8f0e6e21c7e86f67a3a 100644
--- a/ash/common/shelf/wm_shelf.h
+++ b/ash/common/shelf/wm_shelf.h
@@ -20,6 +20,7 @@ namespace ash {
class ShelfLockingManager;
class ShelfView;
+class WmDimmerView;
class WmShelfObserver;
class WmWindow;
@@ -52,7 +53,15 @@ class ASH_EXPORT WmShelf {
virtual ShelfBackgroundType GetBackgroundType() const = 0;
+ // Creates a view that dims shelf items. The returned view is owned by its
+ // widget. Returns null if shelf dimming is not supported (e.g. on mus).
+ // TODO(jamescook): Delete this after material design ships, as MD will not
+ // require shelf dimming. http://crbug.com/614453
+ virtual WmDimmerView* CreateDimmerView(bool disable_animations_for_test) = 0;
+
// Shelf items are slightly dimmed (e.g. when a window is maximized).
+ // TODO(jamescook): Delete this after material design ships, as MD will not
+ // require shelf dimming. http://crbug.com/614453
virtual bool IsDimmed() const = 0;
// Whether the shelf item overflow bubble is visible.
« no previous file with comments | « ash/common/shelf/wm_dimmer_view.h ('k') | ash/mus/bridge/wm_shelf_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698