Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22355002: Revert 215753 "Move native_app_window code to apps areas" (Closed)

Created:
7 years, 4 months ago by benwells
Modified:
7 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 215753 "Move native_app_window code to apps areas" > Move native_app_window code to apps areas > > native_app_window.h -> apps component > platform specific implementations of this are now in c/b/ui/xxx/apps. > > The platform specific implementations should also move to apps/ but > they would currently bring some unwanted dependencies with them; that > can happen later. > > BUG=159366 > > Review URL: https://chromiumcodereview.appspot.com/21344002 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2928 lines) Patch
M trunk/src/apps/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/apps/app_shim/extension_app_shim_handler_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/apps/app_window_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/apps/apps.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/apps/native_app_window.h View 1 chunk +0 lines, -55 lines 0 comments Download
M trunk/src/apps/shell_window.h View 3 chunks +1 line, -5 lines 0 comments Download
M trunk/src/apps/shell_window.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_window/app_window_api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_window/app_window_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 3 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/platform_app_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/platform_app_browsertest_util.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/shell_window_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.h View 3 chunks +4 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/apps/chrome_shell_window_delegate.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/apps/chrome_shell_window_delegate_cocoa.mm View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +0 lines, -194 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +0 lines, -852 lines 0 comments Download
A + trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/extensions/native_app_window.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/gtk/apps/chrome_shell_window_delegate_gtk.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.h View 1 chunk +0 lines, -170 lines 0 comments Download
D trunk/src/chrome/browser/ui/gtk/apps/native_app_window_gtk.cc View 1 chunk +0 lines, -626 lines 0 comments Download
A + trunk/src/chrome/browser/ui/gtk/extensions/native_app_window_gtk.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/apps/chrome_shell_window_delegate_views.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/apps/native_app_window_views.h View 1 chunk +0 lines, -185 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc View 1 chunk +0 lines, -748 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/extensions/native_app_window_views.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/views/extensions/native_app_window_views.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/extensions/shell_window_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 7 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benwells
7 years, 4 months ago (2013-08-06 03:52:14 UTC) #1
benwells
7 years, 4 months ago (2013-08-06 03:52:47 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r215781.

Powered by Google App Engine
This is Rietveld 408576698