third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2235473002: Notify WebMediaPlayer when HTML video enters full screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2235473002: Notify WebMediaPlayer when HTML video enters full screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/web/FullscreenController.h » ('j') | third_party/WebKit/Source/web/FullscreenController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 4bec7cab5832b41887467b6fd69d423848aa384d..097cc1a1bf3b2d82bc98d9efc1e20ccad119d4ff 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -815,9 +815,12 @@ std::unique_ptr<WebMediaPlayer> FrameLoaderClientImpl::createWebMediaPlayer(

HTMLMediaElementEncryptedMedia& encryptedMedia = HTMLMediaElementEncryptedMedia::from(htmlMediaElement);

WebString sinkId(HTMLMediaElementAudioOutputDevice::sinkId(htmlMediaElement));

- return wrapUnique(webFrame->client()->createMediaPlayer(source,

+ std::unique_ptr<WebMediaPlayer> mediaPlayer = wrapUnique(webFrame->client()->createMediaPlayer(source,

client, &encryptedMedia,

encryptedMedia.contentDecryptionModule(), sinkId, webMediaSession));

+ if (htmlMediaElement.isMediaInFullscreen())

+ mediaPlayer->updateMediaInFullscreen(true);

+ return mediaPlayer;

}

std::unique_ptr<WebMediaSession> FrameLoaderClientImpl::createWebMediaSession()