Notify WebMediaPlayer when HTML video enters full screen.

third_party/WebKit/Source/web/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 #include "core/dom/Document.h"
 #include "core/dom/Fullscreen.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/PageScaleConstraintsSet.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "public/platform/WebLayerTreeView.h"
 #include "public/web/WebFrameClient.h"
+#include "third_party/WebKit/Source/core/dom/TagCollection.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebSettingsImpl.h"
 #include "web/WebViewImpl.h"
 
 namespace blink {
 
 FullscreenController* FullscreenController::create(WebViewImpl* webViewImpl)
 {
     return new FullscreenController(webViewImpl);
 }
 
 FullscreenController::FullscreenController(WebViewImpl* webViewImpl)
     : m_webViewImpl(webViewImpl)
     , m_haveEnteredFullscreen(false)
     , m_exitFullscreenPageScaleFactor(0)
     , m_needsScrollAndScaleRestore(false)
     , m_isCancelingFullScreen(false)
 {
 }
 
+// Notify the current media element or all its child media elements when
+// the |element| enters/exits full screen.
+void FullscreenController::updateMediaInFullscreen(Element* element, bool isFullscreen)
+{
+    if (!element)
+        return;
+    if (isHTMLMediaElement(element)) {
+        toHTMLMediaElement(element)->updateMediaInFullscreen(isFullscreen);
+    } else {
+        TagCollection* collection = element->getElementsByTagName("video");

[fs, 2016/08/10 17:30:13]

Drive-by: You should be able to do:

for (HTMLVideoElement& videoElement :
Traversal<HTMLVideoElement>::descendantsOf(element))
    videoElement.update...;

instead of this. Or maybe you want this to be about HTMLMediaElement - it's hard
to tell since there's a bit of a mix here. (I don't think you want to use
getElementsByTagName, since it will add caches et.c.)

[xjz, 2016/08/10 21:33:29]

Thanks for the review! I'll address it in the next patch set. :)

+        for (unsigned i = 0; i < collection->length(); ++i) {
+            Element* childElement = collection->item(i);
+            if (!isHTMLMediaElement(childElement))
+                continue;
+            toHTMLMediaElement(childElement)->updateMediaInFullscreen(isFullscreen);
+        }
+    }
+}
+
 void FullscreenController::didEnterFullscreen()
 {
     if (!m_provisionalFullScreenElement)
         return;
 
     Element* element = m_provisionalFullScreenElement.release();
     Document& document = element->document();
     m_fullScreenFrame = document.frame();
 
     if (!m_fullScreenFrame)
         return;
 
     if (!m_haveEnteredFullscreen) {
         updatePageScaleConstraints(false);
         m_webViewImpl->setPageScaleFactor(1.0f);
         if (m_webViewImpl->mainFrame()->isWebLocalFrame())
             m_webViewImpl->mainFrame()->setScrollOffset(WebSize());
         m_webViewImpl->setVisualViewportOffset(FloatPoint());
         m_haveEnteredFullscreen = true;
     }
 
     Fullscreen::from(document).didEnterFullscreenForElement(element);
     DCHECK_EQ(Fullscreen::currentFullScreenElementFrom(document), element);
 
+    updateMediaInFullscreen(element, true);
     if (isHTMLVideoElement(element)) {
         HTMLVideoElement* videoElement = toHTMLVideoElement(element);
         if (videoElement->usesOverlayFullscreenVideo() && m_webViewImpl->layerTreeView())
             m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);
     }
 }
 
 void FullscreenController::didExitFullscreen()
 {
     if (!m_fullScreenFrame)
@@ skipping 15 matching lines @@
                 // If the video used overlay fullscreen mode, the background was made transparent. Restore the transparency.
                 if (isHTMLVideoElement(element) && m_webViewImpl->layerTreeView())
                     m_webViewImpl->layerTreeView()->setHasTransparentBackground(m_webViewImpl->isTransparent());
 
                 // We need to wait until style and layout are updated in order
                 // to propertly restore scroll offsets since content may not be
                 // overflowing in the same way until they do.
                 if (m_haveEnteredFullscreen)
                     m_needsScrollAndScaleRestore = true;
 
+                updateMediaInFullscreen(element, false);
                 fullscreen->didExitFullscreen();
             }
         }
     }
 
     m_haveEnteredFullscreen = false;
     m_fullScreenFrame.clear();
 }
 
 void FullscreenController::enterFullScreenForElement(Element* element)
@@ skipping 109 matching lines @@
     m_webViewImpl->updateMainFrameLayoutSize();
 }
 
 DEFINE_TRACE(FullscreenController)
 {
     visitor->trace(m_provisionalFullScreenElement);
     visitor->trace(m_fullScreenFrame);
 }
 
 } // namespace blink