VM: Add more array intrinsics.

VM: Add more array intrinsics.

Make building array intrinsics a little easier for future additions.

For now I added a few that are frequently used in Flutter.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb600a9af6d49753cc0c269e5831b9f3f641c347

[Florian Schneider, 2016-08-09 21:14:13]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Florian Schneider, 2016-08-09 22:18:20]

Added Int8, Int16, Uint16 and Uint8clampedList

[rmacnak, 2016-08-10 00:01:42]

https://codereview.chromium.org/2235433002/diff/1/runtime/vm/method_recognizer.h
File runtime/vm/method_recognizer.h (right):

https://codereview.chromium.org/2235433002/diff/1/runtime/vm/method_recognize...
runtime/vm/method_recognizer.h:532: static intptr_t MethodKindToCid(Kind kind);
Consider MethodKindToReceiverCid

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier.cc:447: // Nothing to do.
It's weird that LoadIndexedInstr doesn't consistently load boxed or unboxed
values.

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier.cc:536: RawObject::IsTypedDataClassId(array_cid));
Why no kArrayCid? It's handled for the read case.

[Florian Schneider, 2016-08-10 00:17:36]

https://codereview.chromium.org/2235433002/diff/1/runtime/vm/method_recognizer.h
File runtime/vm/method_recognizer.h (right):

https://codereview.chromium.org/2235433002/diff/1/runtime/vm/method_recognize...
runtime/vm/method_recognizer.h:532: static intptr_t MethodKindToCid(Kind kind);
On 2016/08/10 00:01:42, rmacnak wrote:
> Consider MethodKindToReceiverCid

Done.

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier.cc:447: // Nothing to do.
On 2016/08/10 00:01:42, rmacnak wrote:
> It's weird that LoadIndexedInstr doesn't consistently load boxed or unboxed
> values.

We could change it for the smi-sized typed data arrays. Not sure if it is worth
doing. And object arrays will always have boxed values.

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier.cc:536: RawObject::IsTypedDataClassId(array_cid));
On 2016/08/10 00:01:42, rmacnak wrote:
> Why no kArrayCid? It's handled for the read case.

The List.[]= is still in assembly (see comment below). It has support for
checked mode, that's why I did not port it. We don't have support for checked
mode in the graph intrinsics yet.

[rmacnak, 2016-08-10 00:23:30]

lgtm

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/2235433002/diff/20001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier.cc:536: RawObject::IsTypedDataClassId(array_cid));
On 2016/08/10 00:17:36, Florian Schneider wrote:
> On 2016/08/10 00:01:42, rmacnak wrote:
> > Why no kArrayCid? It's handled for the read case.
> 
> The List.[]= is still in assembly (see comment below). It has support for
> checked mode, that's why I did not port it. We don't have support for checked
> mode in the graph intrinsics yet.

Acknowledged.

[Florian Schneider, 2016-08-10 00:38:57]

Description was changed from

==========
VM: Add more array intrinsics.

Make building array intrinsics a little easier for future additions.

For now I added a few that are frequently used in Flutter.

BUG=
==========

to

==========
VM: Add more array intrinsics.

Make building array intrinsics a little easier for future additions.

For now I added a few that are frequently used in Flutter.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eb600a9af6d49753cc0c269e5831b9f3f641c347
==========

[Florian Schneider, 2016-08-10 00:38:59]

Committed patchset #3 (id:40001) manually as
eb600a9af6d49753cc0c269e5831b9f3f641c347 (presubmit successful).