Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: src/parsing/func-name-inferrer.h

Issue 2235423003: [parser] improve inferred function names for async arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: a better/cheaper mechanic Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/func-name-inferrer.cc » ('j') | src/parsing/func-name-inferrer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/func-name-inferrer.h
diff --git a/src/parsing/func-name-inferrer.h b/src/parsing/func-name-inferrer.h
index ba38ffeb241c348ab8e285a842b08e5f12590615..1e8067eb3fabbd8db4988996834021a57f34cdb5 100644
--- a/src/parsing/func-name-inferrer.h
+++ b/src/parsing/func-name-inferrer.h
@@ -16,6 +16,8 @@ class AstString;
class AstValueFactory;
class FunctionLiteral;
+enum class InferName { Yes, No };
+
// FuncNameInferrer is a stateful class that is used to perform name
// inference for anonymous functions during static analysis of source code.
// Inference is performed in cases when an anonymous function is assigned
@@ -71,6 +73,10 @@ class FuncNameInferrer : public ZoneObject {
}
}
+ int LastNameIndex() const { return this->names_stack_.length() - 1; }
+
+ void RemoveAsyncKeywordAtIndex(int index);
Dan Ehrenberg 2016/08/12 21:29:58 Nit: Rather than exposing these two functions, why
caitp 2016/08/12 21:32:45 1. prone to break with future parser changes, and
Dan Ehrenberg 2016/08/12 21:35:28 The logic would be, how many things from the top o
+
// Infers a function name and leaves names collection state.
void Infer() {
DCHECK(IsOpen());
« no previous file with comments | « no previous file | src/parsing/func-name-inferrer.cc » ('j') | src/parsing/func-name-inferrer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698