Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: src/parsing/parser.cc

Issue 2235423003: [parser] improve inferred function names for async arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: really the last of it Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index 0d16469f3190e582d399752cf5387926922d268a..a00076833681be2eb826342a1dff20f7612c1a1d 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -766,12 +766,13 @@ Literal* ParserTraits::ExpressionFromLiteral(Token::Value token, int pos,
Expression* ParserTraits::ExpressionFromIdentifier(const AstRawString* name,
int start_position,
- int end_position) {
- if (parser_->fni_ != NULL) parser_->fni_->PushVariableName(name);
+ int end_position,
+ InferName infer) {
+ if (infer == InferName::Yes && parser_->fni_ != NULL)
+ parser_->fni_->PushVariableName(name);
return parser_->NewUnresolved(name, start_position, end_position);
}
-
Dan Ehrenberg 2016/08/12 22:07:18 Nit: revert whitespace change
caitp 2016/08/12 22:19:08 Done, and some other style mixups fixed
Expression* ParserTraits::ExpressionFromString(int pos, Scanner* scanner,
AstNodeFactory* factory) {
const AstRawString* symbol = GetSymbol(scanner);
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698