Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/parsing/func-name-inferrer.cc

Issue 2235423003: [parser] improve inferred function names for async arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add braces around single-line if stmt Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/func-name-inferrer.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/parsing/func-name-inferrer.h" 5 #include "src/parsing/func-name-inferrer.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/ast-value-factory.h" 8 #include "src/ast/ast-value-factory.h"
9 #include "src/list-inl.h" 9 #include "src/list-inl.h"
10 10
(...skipping 26 matching lines...) Expand all
37 } 37 }
38 } 38 }
39 39
40 40
41 void FuncNameInferrer::PushVariableName(const AstRawString* name) { 41 void FuncNameInferrer::PushVariableName(const AstRawString* name) {
42 if (IsOpen() && name != ast_value_factory_->dot_result_string()) { 42 if (IsOpen() && name != ast_value_factory_->dot_result_string()) {
43 names_stack_.Add(Name(name, kVariableName), zone()); 43 names_stack_.Add(Name(name, kVariableName), zone());
44 } 44 }
45 } 45 }
46 46
47 void FuncNameInferrer::RemoveAsyncKeywordFromEnd() {
48 DCHECK(names_stack_.length() > 0);
49 DCHECK(names_stack_.last().name->IsOneByteEqualTo("async"));
50 names_stack_.RemoveLast();
51 }
47 52
48 const AstString* FuncNameInferrer::MakeNameFromStack() { 53 const AstString* FuncNameInferrer::MakeNameFromStack() {
49 return MakeNameFromStackHelper(0, ast_value_factory_->empty_string()); 54 return MakeNameFromStackHelper(0, ast_value_factory_->empty_string());
50 } 55 }
51 56
52 const AstString* FuncNameInferrer::MakeNameFromStackHelper( 57 const AstString* FuncNameInferrer::MakeNameFromStackHelper(
53 int pos, const AstString* prev) { 58 int pos, const AstString* prev) {
54 if (pos >= names_stack_.length()) return prev; 59 if (pos >= names_stack_.length()) return prev;
55 if (pos < names_stack_.length() - 1 && 60 if (pos < names_stack_.length() - 1 &&
56 names_stack_.at(pos).type == kVariableName && 61 names_stack_.at(pos).type == kVariableName &&
(...skipping 19 matching lines...) Expand all
76 const AstString* func_name = MakeNameFromStack(); 81 const AstString* func_name = MakeNameFromStack();
77 for (int i = 0; i < funcs_to_infer_.length(); ++i) { 82 for (int i = 0; i < funcs_to_infer_.length(); ++i) {
78 funcs_to_infer_[i]->set_raw_inferred_name(func_name); 83 funcs_to_infer_[i]->set_raw_inferred_name(func_name);
79 } 84 }
80 funcs_to_infer_.Rewind(0); 85 funcs_to_infer_.Rewind(0);
81 } 86 }
82 87
83 88
84 } // namespace internal 89 } // namespace internal
85 } // namespace v8 90 } // namespace v8
OLDNEW
« no previous file with comments | « src/parsing/func-name-inferrer.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698